All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: use ARRAY_SIZE
Date: Tue, 9 Mar 2021 09:09:12 -0300	[thread overview]
Message-ID: <YEdlaO9PSl/68uki@kernel.org> (raw)
In-Reply-To: <1615281145-2122-1-git-send-email-jiapeng.chong@linux.alibaba.com>

Em Tue, Mar 09, 2021 at 05:12:25PM +0800, Jiapeng Chong escreveu:
> Fix the following cppcheck warnings:
> 
> ./tools/perf/tests/demangle-ocaml-test.c:29:34-35: WARNING: Use
> ARRAY_SIZE.

Thanks, applied.

- Arnaldo

 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  tools/perf/tests/demangle-ocaml-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/demangle-ocaml-test.c b/tools/perf/tests/demangle-ocaml-test.c
> index a273ed5..2fac7d7 100644
> --- a/tools/perf/tests/demangle-ocaml-test.c
> +++ b/tools/perf/tests/demangle-ocaml-test.c
> @@ -26,7 +26,7 @@ int test__demangle_ocaml(struct test *test __maybe_unused, int subtest __maybe_u
>  		  "Stdlib.bytes.++" },
>  	};
>  
> -	for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
> +	for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
>  		buf = ocaml_demangle_sym(test_cases[i].mangled);
>  		if ((buf == NULL && test_cases[i].demangled != NULL)
>  				|| (buf != NULL && test_cases[i].demangled == NULL)
> -- 
> 1.8.3.1
> 

-- 

- Arnaldo

      reply	other threads:[~2021-03-09 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  9:12 [PATCH] perf tools: use ARRAY_SIZE Jiapeng Chong
2021-03-09 12:09 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEdlaO9PSl/68uki@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.