All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] max_map_count: Add judgment of abnormal situation
Date: Tue, 9 Mar 2021 13:46:16 +0100	[thread overview]
Message-ID: <YEduGMNAv1V+sQVs@pevik> (raw)
In-Reply-To: <20210309120914.711-1-zhaogongyi@huawei.com>

Hi,

> When CommitLimit - Committed_AS < 128, there is no post processing,
> and the test will report "TBROK: Test haven't reported results".

> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
>  testcases/kernel/mem/tunable/max_map_count.c | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/testcases/kernel/mem/tunable/max_map_count.c b/testcases/kernel/mem/tunable/max_map_count.c
> index aa70fde59..ffc53cbb5 100644
> --- a/testcases/kernel/mem/tunable/max_map_count.c
> +++ b/testcases/kernel/mem/tunable/max_map_count.c
> @@ -162,6 +162,8 @@ static void max_map_count_test(void)
>  	max_iters = memfree / sysconf(_SC_PAGESIZE) * 1024 - 64;
>  	if (max_iters > MAX_MAP_COUNT)
>  		max_iters = MAX_MAP_COUNT;
> +	if (max_iters < 0)
> +		tst_brk(TCONF, "Test nees max_iters > 0, test skipped");
typo: nees => needs (no need to repost, can be changed during merge).

Reviewed-by: Petr Vorel <pvorel@suse.cz>

You seems to exploring limits. Out of curiosity, which system / hw do you test?

Kind regards,
Petr

>  	max_maps = MAP_COUNT_DEFAULT;
>  	while (max_maps <= max_iters) {

  reply	other threads:[~2021-03-09 12:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 12:09 [LTP] [PATCH] max_map_count: Add judgment of abnormal situation Zhao Gongyi
2021-03-09 12:46 ` Petr Vorel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-09 13:17 zhaogongyi
2021-03-09 14:54 ` Petr Vorel
2021-03-10  2:03 Zhao Gongyi
2021-03-10 10:26 ` Petr Vorel
2021-03-10  2:06 zhaogongyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEduGMNAv1V+sQVs@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.