All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)
Date: Tue, 9 Mar 2021 17:16:29 +0000	[thread overview]
Message-ID: <YEetbR063NjfBPSV@redhat.com> (raw)
In-Reply-To: <20210309165035.967853-1-thuth@redhat.com>

On Tue, Mar 09, 2021 at 05:50:35PM +0100, Thomas Huth wrote:
> When trying to remove the -usbdevice option, there were complaints that
> "-usbdevice braille" is still a very useful shortcut for some people.
> Thus we never remove this option. Since it's not such a big burden to
> keep it around, and it's also convenient in the sense that you don't
> have to worry to enable a host controller explicitly with this option,
> we should remove it from he deprecation list again, and rather properly
> document the possible device for this option instead.
> 
> However, there is one exception: "-usbdevice audio" should go away, since
> audio devices without "audiodev=..." parameter are also on the deprecation
> list and you cannot use "-usbdevice audio" with "audiodev".
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2: Add an entry to removed-features.rst
> 
>  docs/system/deprecated.rst       |  9 --------
>  docs/system/removed-features.rst |  8 +++++++
>  hw/usb/dev-audio.c               |  1 -
>  qemu-options.hx                  | 38 +++++++++++++++++++++++++++-----
>  softmmu/vl.c                     |  2 --
>  5 files changed, 40 insertions(+), 18 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-03-09 19:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 16:50 [PATCH v2] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed) Thomas Huth
2021-03-09 17:16 ` Daniel P. Berrangé [this message]
2021-03-09 17:21 ` Paolo Bonzini
2021-03-10 12:14   ` Gerd Hoffmann
2021-03-10 10:02 ` Gerd Hoffmann
2021-03-10 10:06   ` Thomas Huth
2021-03-10 13:17 ` Markus Armbruster
2021-03-10 15:02   ` Samuel Thibault
2021-03-10 15:26     ` Paolo Bonzini
2021-03-10 15:31       ` Daniel P. Berrangé
2021-03-10 15:43         ` Samuel Thibault
2021-03-10 15:44   ` Paolo Bonzini
2021-03-10 16:06   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEetbR063NjfBPSV@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.