From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: agross@kernel.org, linus.walleij@linaro.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets
Date: Tue, 9 Mar 2021 14:05:28 -0600 [thread overview]
Message-ID: <YEfVCPvsAP2FpYsz@builder.lan> (raw)
In-Reply-To: <1614662511-26519-1-git-send-email-rnayak@codeaurora.org>
On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote:
> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 8daccd5..49c4347 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = {
> [172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _),
> [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
> [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
> - [175] = UFS_RESET(ufs_reset, 0x1be000),
> - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0),
> - [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6),
> - [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3),
> - [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0),
> - [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6),
> - [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3),
> - [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0),
> + [175] = UFS_RESET(ufs_reset, 0xbe000),
> + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
> + [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
> + [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
> + [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
> + [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6),
> + [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3),
> + [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0),
> };
>
> static const struct msm_pinctrl_soc_data sc7280_pinctrl = {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2021-03-09 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 5:21 [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Rajendra Nayak
2021-03-02 5:21 ` [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations Rajendra Nayak
2021-03-09 20:11 ` Bjorn Andersson
2021-03-09 20:05 ` Bjorn Andersson [this message]
2021-03-10 23:52 ` [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets Linus Walleij
2021-03-11 10:40 ` Andy Shevchenko
2021-03-11 14:40 ` Linus Walleij
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEfVCPvsAP2FpYsz@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.