From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
olteanv@gmail.com, netdev@vger.kernel.org
Subject: Re: [RFC net] net: dsa: Centralize validation of VLAN configuration
Date: Wed, 10 Mar 2021 01:30:33 +0100 [thread overview]
Message-ID: <YEgTKSS+3ZmeXB66@lunn.ch> (raw)
In-Reply-To: <87h7lkow44.fsf@waldekranz.com>
On Tue, Mar 09, 2021 at 10:28:11PM +0100, Tobias Waldekranz wrote:
Hi Tobias
As with Florian, i've not been following the discussion.
> Yeah sorry, I can imagine that makes no sense whatsoever without the
> context of the recent discussions. It is basically guarding against this
> situation:
>
> .100 br0 .100
> \ / \ /
> lan0 lan1
>
> $ ip link add dev br0 type bridge vlan_filtering 1
> $ ip link add dev lan0.100 link lan0 type vlan id 100
> $ ip link add dev lan1.100 link lan1 type vlan id 100
> $ ip link set dev lan0 master br0
> $ ip link set dev lan1 master br0 # This should fail
Given the complexity at hand, maybe consider putting this all into the
code?
Andrew
next prev parent reply other threads:[~2021-03-10 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 18:42 [RFC net] net: dsa: Centralize validation of VLAN configuration Tobias Waldekranz
2021-03-09 20:40 ` Florian Fainelli
2021-03-09 21:28 ` Tobias Waldekranz
2021-03-09 22:01 ` Vladimir Oltean
2021-03-10 0:36 ` Andrew Lunn
2021-03-14 21:40 ` Tobias Waldekranz
2021-03-15 9:29 ` Vladimir Oltean
2021-03-10 0:30 ` Andrew Lunn [this message]
2021-03-10 0:51 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEgTKSS+3ZmeXB66@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.