From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: stable <stable@vger.kernel.org>,
"Jernej Škrabec" <jernej.skrabec@siol.net>,
"Nicolas Dufresne" <nicolas@ndufresne.ca>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>
Subject: Re: [PATCH FOR stable v5.11] media: cedrus: Remove checking for required controls
Date: Wed, 10 Mar 2021 13:05:30 +0100 [thread overview]
Message-ID: <YEi2CueFSqk/6lnb@kroah.com> (raw)
In-Reply-To: <f938a1ba-d9ae-3b39-a066-60504a9e6c12@xs4all.nl>
On Wed, Mar 10, 2021 at 11:49:38AM +0100, Hans Verkuil wrote:
> From: Jernej Skrabec <jernej.skrabec@siol.net>
>
> [ Upstream commit 7072db89572135f28cad65f15877bf7e67cf2ff8 ]
>
> According to v4l2 request api specifications, it's allowed to skip
> control if its content isn't changed for performance reasons. Cedrus
> driver predates that, so it has implemented mechanism to check if all
> required controls are included in one request.
>
> Conform to specifications with removing that mechanism.
>
> Note that this mechanism with static required flag isn't very good
> anyway because need for control is usually signaled in other controls.
>
> Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
> Without this patch the H264 cedrus support is non-compliant, and since 5.11
> was the first kernel with a stable H264 stateless codec ABI it would be
> good to have this merged for 5.11 so the cedrus driver can be used with
> H264.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-03-10 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 10:49 [PATCH FOR stable v5.11] media: cedrus: Remove checking for required controls Hans Verkuil
2021-03-10 12:05 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEi2CueFSqk/6lnb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.