All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCh v2] clock_gettime04: print more info to help debugging
Date: Wed, 10 Mar 2021 14:11:20 +0100	[thread overview]
Message-ID: <YEjFeGrGsYrr/n3U@pevik> (raw)
In-Reply-To: <CAEemH2c0LQPc1dY=ErruKHOGU3OXeKXQgh3VMaYveZN+qVnCKA@mail.gmail.com>

Hi Li,

> > From a long term, I'd like some easy solution when printing would be
> > handled in
> > the library. Some time ago I posted a patch which turned .test_variants
> > from int
> > into array of string description [1]. Cyril didn't see much value at it and

> I look back at patch[1], IMHO, splitting the test variant struct is not a
> good idea.
> I'd rather go print variants[i].desc in the library directly but not split
> it to make
> struct here and there :).
Thanks a lot for having a look. Make sense, I'll try to send v2 soon.

> > didn't like that it introduced more ifdefs (together with Viresh).
> > But now we have docparse, could we reconsider this approach? Maybe we
> > could keep
> > .test_variants and introduce .test_variants_desc for tests which are
> > simple enough.
> > Or, maybe there is a cleaner solution for clock_adjtime0* tests which I
> > don't
> > see.


> Maybe there is.  We can have more time to thinking/discussing this.

> So, would you mind if I merge this V2 patch first?

> (Since we're encountering a sporadical(we can't reproduce it manually)
> failure. Hope this can print more useful info to locate the issue.)

Although I'd slightly prefer if it printed everything once in the setup, it's
not important and we've already spent quite a lot of time with it, so sure,
go ahead :)

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

  reply	other threads:[~2021-03-10 13:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  8:00 [LTP] [PATCh v2] clock_gettime04: print more info to help debugging Li Wang
2021-03-09  9:45 ` Viresh Kumar
2021-03-09 11:52   ` Petr Vorel
2021-03-09 11:56     ` Viresh Kumar
2021-03-10  8:34       ` Li Wang
2021-03-10  8:43         ` Viresh Kumar
2021-03-10 10:11           ` Petr Vorel
2021-03-10 12:12             ` Li Wang
2021-03-10 13:11               ` Petr Vorel [this message]
2021-03-10 13:32                 ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEjFeGrGsYrr/n3U@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.