From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, jvusich@amazon.com,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] builtin/init-db: handle bare clones when core.bare set to false
Date: Wed, 10 Mar 2021 23:33:22 +0000 [thread overview]
Message-ID: <YElXQhgTFLS61MuF@camp.crustytoothpaste.net> (raw)
In-Reply-To: <xmqq7dmeip1v.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On 2021-03-10 at 23:09:32, Junio C Hamano wrote:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > diff --git a/t/t5606-clone-options.sh b/t/t5606-clone-options.sh
> > index 52e5789fb0..c2b71e78c5 100755
> > --- a/t/t5606-clone-options.sh
> > +++ b/t/t5606-clone-options.sh
> > @@ -104,6 +104,14 @@ test_expect_success 'redirected clone -v does show progress' '
> >
> > '
> >
> > +test_expect_success 'clone does not segfault with --bare and core.bare=false' '
> > + test_config_global core.bare false &&
> > + git clone --bare parent clone-bare &&
>
> Because "git clone" does so many different things from the normal
> codepath in the "local" codepath, I'd prefer to see this one done
> with the "--no-local" option (or alternatively, we could test both,
> but that may be overkill).
I can reroll with that.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2021-03-10 23:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 0:06 bug: conflicting core.bare setting causes segfault during bare clone Vusich, Joseph
2021-03-03 23:59 ` brian m. carlson
2021-03-04 1:13 ` Junio C Hamano
2021-03-04 11:48 ` Vusich, Joseph
2021-03-08 13:17 ` [PATCH] builtin/init-db: handle bare clones when core.bare set to false brian m. carlson
2021-03-08 16:43 ` Eric Sunshine
2021-03-08 23:22 ` brian m. carlson
2021-03-10 1:11 ` [PATCH v2] " brian m. carlson
2021-03-10 23:09 ` Junio C Hamano
2021-03-10 23:33 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YElXQhgTFLS61MuF@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jvusich@amazon.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.