From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 6/7] tst_test.sh: Run cleanup also after test timeout
Date: Thu, 11 Mar 2021 15:47:21 +0100 [thread overview]
Message-ID: <YEoteW3o3A7eijkB@pevik> (raw)
In-Reply-To: <YEofzk8nrVepc78j@yuki.lan>
Hi Cyril, Li,
> > > > +_tst_run_timer()
> > > Hmm, this name is not good than before, or rename to _tst_kill_timer_pid(),
> > > _tst_stop_timer()?
> > Good point. I slightly prefer _tst_stop_timer, but no hard feeling about it.
> Or _tst_kill_test()?
+1
> > > > +{
> > > > + tst_res TBROK "test killed, timeout! If you are running on slow
> > > > machine, try exporting LTP_TIMEOUT_MUL > 1"
> > > > + kill -INT -$pid
> > > > + sleep 5
> > > > + kill -KILL -$pid
> Maybe we should change the messages to reflect what is happening and
> maybe we should check if the test is still running before sending
> SIGKILL with kill -0 $pid?
> tst_res TBROK "Test timeouted, sending SIGINT, ...."
> kill -INT -$pid
> sleep 5
> if kill -0 $pid 2>&1 > /dev/null; then
> tst_res TBROK "Test still running, sending SIGKILL"
> kill -KILL -$pid
> fi
> We can also bussy loop wait for the process to terminate, e.g. loop 10
> times with sleep 1 in the body and break the loop if kill -0 $pid
> returns failure.
Busy loop wait 10 times + final -KILL make sense to me. I'm going to merge first
five commits and send v2 this + the last commit.
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-11 14:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 22:02 [LTP] [PATCH 0/7] zram cleanup, tst_set_timeout(timeout) Petr Vorel
2021-03-01 22:02 ` [LTP] [PATCH 1/7] zram: Calculate dev_num variable Petr Vorel
2021-03-01 22:02 ` [LTP] [PATCH 2/7] zram01.sh: Generate test setup variables in setup Petr Vorel
2021-03-01 22:02 ` [LTP] [PATCH 3/7] zram: Add zram_compress_alg() to zram02.sh Petr Vorel
2021-03-01 22:02 ` [LTP] [PATCH 4/7] zram: Move test specific functions out of zram_lib.sh Petr Vorel
2021-03-01 22:02 ` [LTP] [PATCH 5/7] tst_test.sh: Introduce tst_set_timeout(timeout) Petr Vorel
2021-03-02 8:53 ` Li Wang
2021-03-02 10:04 ` Cyril Hrubis
2021-03-02 10:26 ` Petr Vorel
2021-03-02 13:50 ` Li Wang
2021-03-02 10:17 ` Petr Vorel
2021-03-01 22:02 ` [LTP] [PATCH 6/7] tst_test.sh: Run cleanup also after test timeout Petr Vorel
2021-03-02 8:59 ` Li Wang
2021-03-02 10:20 ` Petr Vorel
2021-03-11 13:49 ` Cyril Hrubis
2021-03-11 14:47 ` Petr Vorel [this message]
2021-03-01 22:02 ` [LTP] [PATCH 7/7] zram: Increase timeout according to used devices Petr Vorel
2021-03-02 9:07 ` Li Wang
2021-03-11 13:30 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEoteW3o3A7eijkB@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.