From: Greg KH <gregkh@linuxfoundation.org>
To: Manoj Gupta <manojgupta@google.com>
Cc: sashal@kernel.org, joe.lawrence@redhat.com,
clang-built-linux@googlegroups.com, stable@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Luis Lozano <llozano@google.com>, Jian Cai <jiancai@google.com>,
Doug Anderson <dianders@google.com>
Subject: Re: 9c8e2f6d3d36 for linux-4.{4,9,14,19}-y
Date: Fri, 12 Mar 2021 11:07:35 +0100 [thread overview]
Message-ID: <YEs9Zz9oldcbDedI@kroah.com> (raw)
In-Reply-To: <CAH=QcsjHmWdLU6u-imNYWU2v=9ieP8bOk22FLERUd+rVUeqZNw@mail.gmail.com>
On Wed, Mar 10, 2021 at 05:09:30PM -0800, Manoj Gupta wrote:
> Dear stable kernel maintainers,
>
> Please consider applying the following patch for 4.{4,9,14,19}-y
> kernel branches.
> 9c8e2f6d3d36 scripts/recordmcount.{c,pl}: support -ffunction-sections
> .text.* section names
>
> It is needed to fix a kernel boot issue with trunk clang compiler
> which now puts functions with __cold attribute to .text.unlikely
> section. Please feel free to check
> https://bugs.chromium.org/p/chromium/issues/detail?id=1184483 for
> details.
>
> 9c8e2f6d3d36 applies cleanly for 4.14 and 4.19.
> For 4.4 and 4.9, a slight changed diff for scripts/recordmcount.c is
> needed to apply the patch cleanly. The final changed lines are still
> the same.
>
> scripts/recordmcount.c diff for 4.4 and 4.9 kernel.
>
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -362,7 +362,7 @@ static uint32_t (*w2)(uint16_t);
> static int
> is_mcounted_section_name(char const *const txtname)
> {
> - return strcmp(".text", txtname) == 0 ||
> + return strncmp(".text", txtname, 5) == 0 ||
> strcmp(".ref.text", txtname) == 0 ||
> strcmp(".sched.text", txtname) == 0 ||
> strcmp(".spinlock.text", txtname) == 0 ||
>
Can you provide properly backported versions for 4.4 and 4.9 so I can
apply them? Hand-editing them doesn't really work well...
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-12 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 1:09 9c8e2f6d3d36 for linux-4.{4,9,14,19}-y Manoj Gupta
2021-03-12 10:07 ` Greg KH [this message]
2021-03-12 20:39 ` [PATCH] scripts/recordmcount.{c,pl}: support -ffunction-sections .text.* section names Manoj Gupta
2021-03-12 20:42 ` Manoj Gupta
2021-03-12 20:52 ` Nick Desaulniers
2021-03-12 22:17 ` [PATCH v2] " Manoj Gupta
2021-03-13 13:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEs9Zz9oldcbDedI@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=dianders@google.com \
--cc=jiancai@google.com \
--cc=joe.lawrence@redhat.com \
--cc=llozano@google.com \
--cc=manojgupta@google.com \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.