All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: imx_keypad - convert to a DT-only driver
Date: Sat, 27 Mar 2021 12:37:10 -0700	[thread overview]
Message-ID: <YF+JZsCSY4C+StK5@google.com> (raw)
In-Reply-To: <CAOMZO5A36YbA59v4NmEFjhkcXF5fTDRn1204_U3+X86qfbqB9g@mail.gmail.com>

Hi Fabio,

On Sat, Mar 27, 2021 at 04:14:46PM -0300, Fabio Estevam wrote:
> Hi Dmitry,
> 
> On Tue, Mar 16, 2021 at 10:36 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > i.MX has been converted to a DT-only platform, so make the
> > adjustments to the driver to convert it to a DT-only driver.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > Changes since v1:
> > - Remove dev_get_platdata() and the pdev->dev.of_node check (Dmitry).
> 
> Does v2 look good?

Sorry, I am still confused why we need the OF dependency given that the
driver can be compiled without CONFIG_OF (of_device_id is always
defined) and, as far as I understand, while entire ARCH_MXC is not
selecting OF, all real users are converted to OF.

I guess if we really need this OF dependency we can make it:

	depends on (ARCH_MXC && OF) || COMPILE_TEST

Please let me know.

Thanks.

-- 
Dmitry

  reply	other threads:[~2021-03-27 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 13:35 [PATCH v2] Input: imx_keypad - convert to a DT-only driver Fabio Estevam
2021-03-27 19:14 ` Fabio Estevam
2021-03-27 19:37   ` Dmitry Torokhov [this message]
2021-03-27 19:44     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF+JZsCSY4C+StK5@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.