From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Goswami, Sanket" <Sanket.Goswami@amd.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
Subject: Re: [PATCH] i2c: add i2c bus driver for amd navi gpu
Date: Fri, 26 Mar 2021 12:40:23 +0200 [thread overview]
Message-ID: <YF26F8IFmbo80rMq@smile.fi.intel.com> (raw)
In-Reply-To: <617d0164-1290-250f-ae34-828c6b4b390a@amd.com>
On Fri, Mar 26, 2021 at 03:53:34PM +0530, Goswami, Sanket wrote:
> On 25-Mar-21 22:35, Andy Shevchenko wrote:
> > On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote:
> >> On 09-Mar-21 19:56, Andy Shevchenko wrote:
> >>> On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote:
...
> > And I think I already have told you that I prefer to see rather MODEL_ quirk.
>
> I did not find MODEL_ quirk reference in the PCI device tree, It is actually
> used in platform device tree which is completely different from our PCI
> based configuration, can you please provide some reference of MODEL_ quirk
> which will be part of the PCI device tree?
I meant the name of new definition for quirk.
...
> >>> Also why (1) and this can't be instantiated from ACPI / DT?
> >> It is in line with the existing PCIe-based DesignWare driver,
> >> A similar approach is used by the various vendors.
> >
> > Here is no answer to the question. What prevents you to fix your ACPI tables or
> > DT?
> >
> > We already got rid of FIFO hard coded values, timings are harder to achieve,
> > but we expect that new firmwares will provide values in the ACPI tables.
>
> AMD NAVI GPU card is the PCI initiated driver, not ACPI initiated,
Which doesn't prevent to have an ACPI companion (via description in the
tables).
> and also
> It does not contain a corresponding ACPI match table.
Yes, that's what should be done in the firmware.
At least for the new version of firmware consider to add proper data into the
tables.
> Moreover, AMD NAVI GPU
> based products are already in the commercial market hence going by this
> approach will break the functionalities for the same.
This is quite bad and unfortunate. So, you have to elaborate this in the commit
message.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-26 10:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:31 [PATCH] i2c: add i2c bus driver for amd navi gpu Sanket Goswami
2021-03-09 14:23 ` kernel test robot
2021-03-09 14:23 ` kernel test robot
2021-03-09 14:26 ` Andy Shevchenko
2021-03-22 16:56 ` Goswami, Sanket
2021-03-25 17:05 ` Andy Shevchenko
2021-03-26 10:23 ` Goswami, Sanket
2021-03-26 10:40 ` Andy Shevchenko [this message]
2021-03-29 5:55 ` Goswami, Sanket
2021-03-29 12:36 ` Andy Shevchenko
2021-03-09 15:35 ` kernel test robot
2021-03-09 15:35 ` kernel test robot
2021-03-09 15:36 ` kernel test robot
2021-03-09 15:36 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-11-27 19:30 [PATCH] i2c: add i2c bus driver for AMD NAVI GPU Sanjay R Mehta
2020-11-30 11:19 ` Andy Shevchenko
2020-12-02 4:44 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF26F8IFmbo80rMq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Nehal-Bakulchandra.shah@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.