From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB9AC433C1 for ; Fri, 26 Mar 2021 12:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5D4C6191F for ; Fri, 26 Mar 2021 12:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbhCZMSl (ORCPT ); Fri, 26 Mar 2021 08:18:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49064 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbhCZMSS (ORCPT ); Fri, 26 Mar 2021 08:18:18 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lPlPq-00D7ub-BM; Fri, 26 Mar 2021 13:18:14 +0100 Date: Fri, 26 Mar 2021 13:18:14 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, ecree.xilinx@gmail.com, michael.chan@broadcom.com, paul.greenwalt@intel.com, rajur@chelsio.com, jaroslawx.gawin@intel.com, vkochan@marvell.com, alobakin@pm.me, snelson@pensando.io, shayagr@amazon.com, ayal@nvidia.com, shenjian15@huawei.com, saeedm@nvidia.com, mkubecek@suse.cz, roopa@nvidia.com Subject: Re: [PATCH net-next v2 5/6] ethtool: fec: sanitize ethtool_fecparam->fec Message-ID: References: <20210326020727.246828-1-kuba@kernel.org> <20210326020727.246828-6-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326020727.246828-6-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 25, 2021 at 07:07:26PM -0700, Jakub Kicinski wrote: > Reject NONE on set, this mode means device does not support > FEC so it's a little out of place in the set interface. > > This should be safe to do - user space ethtool does not allow > the use of NONE on set. A few drivers treat it the same as OFF, > but none use it instead of OFF. > > Similarly reject an empty FEC mask. The common user space tool > will not send such requests and most drivers correctly reject > it already. > > v2: - use mask not bit pos > > Signed-off-by: Jakub Kicinski Reviewed-by: Andrew Lunn Andrew