From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A459C433DB for ; Fri, 26 Mar 2021 12:29:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16F5C61971 for ; Fri, 26 Mar 2021 12:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbhCZM2e (ORCPT ); Fri, 26 Mar 2021 08:28:34 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49144 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbhCZM2A (ORCPT ); Fri, 26 Mar 2021 08:28:00 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lPlZF-00D80L-U0; Fri, 26 Mar 2021 13:27:57 +0100 Date: Fri, 26 Mar 2021 13:27:57 +0100 From: Andrew Lunn To: Joakim Zhang Cc: Florian Fainelli , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" Subject: Re: FEC unbind/bind feature Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > Please wrap your lines at around 75 characters. Standard netiquette rules for > > emails apply to all Linux lists. > > Ok, thanks. Please keep fighting with your email client, > Yes, you are right. It should be always fine for single FEC controller, and unbind/bind one by one should also be fine for dual FEC controllers which share one MDIO bus. I test on i.MX6UL, i.MX8MM/MP. > > > It seems to abstract an independent MDIO bus for dual FEC instances. I > > > look at the MDIO dt bindings, it seems support such case as it has > > > "reg" > > > property. (Documentation/devicetree/bindings/net/mdio.yaml) > > > > You can have fully standalone MDIO bus drivers. You generally do this when the > > MDIO bus registers are in their own address space, which you can ioremap() > > separately from the MAC registers. Take a look in drivers/net/mdio/. > > > > > From your opinions, do you think it is necessary to improve it? > > > > What is you use case for unbinding/binding the FEC? > > Users may want to unbind FEC driver, and then bind to FEC UIO driver, such as for DPDK use case to improve the throughput. You could blacklist the FEC driver so it never loads. Or change the compatible string so it only matches the DPDK driver. Or use XDP :-) Andrew