From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B64C433DB for ; Tue, 16 Mar 2021 12:54:01 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 530086504F for ; Tue, 16 Mar 2021 12:54:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 530086504F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BFE944B5AB; Tue, 16 Mar 2021 08:54:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7xsplGi2jVgj; Tue, 16 Mar 2021 08:53:59 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B24C84B405; Tue, 16 Mar 2021 08:53:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6E65A4B24C for ; Tue, 16 Mar 2021 08:53:58 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R2NFHwmodB-8 for ; Tue, 16 Mar 2021 08:53:57 -0400 (EDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 43EC94B24B for ; Tue, 16 Mar 2021 08:53:57 -0400 (EDT) Received: by mail-wr1-f42.google.com with SMTP id k8so7364756wrc.3 for ; Tue, 16 Mar 2021 05:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YhH9qDZ7UYlwG27TDzW+MnA+T1mgb+aVZ+2GGb51p/w=; b=TIM3a2FTxwFa4dUcd5GxP31tl7wKFqCYuHW1RCSsYGdx7PfVWPHK4rzncWHc1Wi7o/ d2c3Bkjb6IsOlZBuk6rn54lnPctO+Kra4AXoGrH+tT7zTPwClbOKbkcQ9wbb+rGcmK3R HUv2leFtOacjysyoAyc9t7BDaMfJ4EoYue76wFoHsTLkgUWeXl3xaHcENikgGzeEy2QY 2AZ211B1x7jPAMLqwIUBhegCNV14sv6beMz36g1/kzF9w2L1N5tTi2BNhRJlm8CoN6hW YRmJP03BcUurDZRpbei0PZIRVONf2SXSbDMfZVUktwxp5jFGb+cUr/XXkKviaSfLxp2l a+7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YhH9qDZ7UYlwG27TDzW+MnA+T1mgb+aVZ+2GGb51p/w=; b=MR3o5zfMOE7ZIo6zKcoQMxK2mlWldQWU/ZX+DVaikJsTC4+UuR2K7rcAbwVCXfx6rh VeSJ8tUTD9z4o2frns8sOrx9t+lMHhX9BznKdwSoq4zdzKOyE98lqlQQJH9dUklz2qiu UZFR/mCzbeU96wDsR/0PN7c8NJkJwAfDL1zUVgoeDEeDf1RXaPvwSqF9lVmkLkdAhQyu McA5Yxtmle3OGCv5xKskSMQi06WEWIG6kXCkhNaHf/V/vojysvokHXRbj+n7XFl4zQyL fpRZy6f+T464RI45OjRJQ7AlZGzps4YLLIDCyYxT6wjFIZ1SvKuxpw6zjY0TQyGVEiaB juIg== X-Gm-Message-State: AOAM533LgNIHXK+F+/JUC9u25Te2A6xTuXzt5B10izrpKDCY2Ne9KiIs 0c/3n1VvEjUt1gmNhG5JF5ug6Q== X-Google-Smtp-Source: ABdhPJxGSb04ZRPkSOl7qX8cOElBY2c0oVdgp7I4wyUE4jKYntg8bGYi4e+uakNSKN8b4ZKHwnBiBg== X-Received: by 2002:adf:fe48:: with SMTP id m8mr4694101wrs.135.1615899235994; Tue, 16 Mar 2021 05:53:55 -0700 (PDT) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id b186sm3074930wmc.44.2021.03.16.05.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 05:53:55 -0700 (PDT) Date: Tue, 16 Mar 2021 12:53:53 +0000 From: Quentin Perret To: Mate Toth-Pal Subject: Re: [PATCH v5 33/36] KVM: arm64: Wrap the host with a stage 2 Message-ID: References: <20210315143536.214621-1-qperret@google.com> <20210315143536.214621-34-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kernel-team@android.com, android-kvm@google.com, catalin.marinas@arm.com, seanjc@google.com, tabba@google.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, will@kernel.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVHVlc2RheSAxNiBNYXIgMjAyMSBhdCAxMzoyODo0MiAoKzAxMDApLCBNYXRlIFRvdGgtUGFs IHdyb3RlOgo+IFRlc3RpbmcgdGhlIGxhdGVzdCB2ZXJzaW9uIG9mIHRoZSBwYXRjaHNldCwgd2Ug c2VlbSB0byBoYXZlIGZvdW5kIGFub3RoZXIKPiB0aGluZyByZWxhdGVkIHRvIEZFQVRfUzJGV0Iu CgpBcmdoISBJIHdpc2ggSSBjb3VsZCBwdXQgbXkgaGFuZHMgb24gaGFyZHdhcmUgd2l0aCBGV0Iu IFRoYW5rcyBhZ2FpbiBmb3IKdGhlIHJlcG9ydC4KCj4gVGhpcyBmdW5jdGlvbiBhbHdheXMgc2V0 cyBOb3JtYWwgbWVtb3J5IGluIHRoZSBzdGFnZSAyIHRhYmxlLCBldmVuIGlmIHRoZQo+IGFkZHJl c3MgaW4gc3RhZ2UgMSB3YXMgbWFwcGVkIGFzIGEgZGV2aWNlIG1lbW9yeS4gSG93ZXZlciB3aXRo IHRoZSBjdXJyZW50Cj4gc2V0dGluZ3MgZm9yIG5vcm1hbCBtZW1vcnkgKGkuZS4gTVRfUzJfRldC X05PUk1BTCBiZWluZyBkZWZpbmVkIHRvIDYpCj4gYWNjb3JkaW5nIHRvIHRoZSBhcmNoaXRlY3R1 cmUgKFNlZSBBcm0gQVJNLCAnRDUuNS41IFN0YWdlIDIgbWVtb3J5IHJlZ2lvbgo+IHR5cGUgYW5k IGNhY2hlYWJpbGl0eSBhdHRyaWJ1dGVzIHdoZW4gRkVBVF9TMkZXQiBpcyBpbXBsZW1lbnRlZCcp IHRoZQo+IHJlc3VsdGluZyBhdHRyaWJ1dGVzIHdpbGwgYmUgJ05vcm1hbCBXcml0ZS1CYWNrJyBl dmVuIGlmIHRoZSBzdGFnZSAxIG1hcHBpbmcKPiBzZXRzIGRldmljZSBtZW1vcnkuIEFjY2Vzc2lu ZyBkZXZpY2UgbWVtb3J5IG1hcHBlZCBsaWtlIHRoaXMgY2F1c2VzIGFuCj4gU0Vycm9yIG9uIHNv bWUgcGxhdGZvcm1zIHdpdGggRkVBVF9TMkZXQiBiZWluZyBpbXBsZW1lbnRlZC4KClJpZ2h0LgoK PiBDaGFuZ2luZyB0aGUgdmFsdWUgb2YgTVRfUzJfRldCX05PUk1BTCB0byA3IHdvdWxkIGNoYW5n ZSB0aGlzIGJlaGF2aW9yLCBhbmQKPiB0aGUgcmVzdWx0aW5nIG1lbW9yeSB0eXBlIHdvdWxkIGJl IGRldmljZS4KClNvdW5kcyBsaWtlIHRoZSBjb3JyZWN0IGZpeCBoZXJlIC0tIHNlZSBiZWxvdy4K Cj4gQW5vdGhlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBhZGQgYW4gZWxzZSBicmFuY2ggdG8gdGhl IGxhc3QgJ2lmJyBhYm92ZSBsaWtlCj4gdGhpczoKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02 NC9rdm0vaHlwL252aGUvbWVtX3Byb3RlY3QuYwo+IGIvYXJjaC9hcm02NC9rdm0vaHlwL252aGUv bWVtX3Byb3RlY3QuYwo+IGluZGV4IGZmZmE0MzJjZTNlYi4uNTRlNWQzYjBiMmUxIDEwMDY0NAo+ IC0tLSBhL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL21lbV9wcm90ZWN0LmMKPiArKysgYi9hcmNo L2FybTY0L2t2bS9oeXAvbnZoZS9tZW1fcHJvdGVjdC5jCj4gQEAgLTIxNCw2ICsyMTQsOCBAQCBz dGF0aWMgaW50IGhvc3Rfc3RhZ2UyX2lkbWFwKHU2NCBhZGRyKQo+IAo+IMKgwqDCoMKgwqDCoMKg IGlmIChpc19tZW1vcnkpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByb3QgfD0g S1ZNX1BHVEFCTEVfUFJPVF9YOwo+ICvCoMKgwqDCoMKgwqAgZWxzZQo+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHByb3QgfD0gS1ZNX1BHVEFCTEVfUFJPVF9ERVZJQ0U7Cj4gCj4gwqDC oMKgwqDCoMKgwqAgaHlwX3NwaW5fbG9jaygmaG9zdF9rdm0ubG9jayk7Cj4gwqDCoMKgwqDCoMKg wqAgcmV0ID0ga3ZtX3BndGFibGVfc3RhZ2UyX2ZpbmRfcmFuZ2UoJmhvc3Rfa3ZtLnBndCwgYWRk ciwgcHJvdCwKPiAmcmFuZ2UpOwoKV2hpbGUgdGhpcyB3b3VsZCB3b3JrIGluIHRoaXMgcGFydGlj dWxhciBjYXNlLCBJIGRvbid0IHRoaW5rIHdlIHNob3VsZApmb3JjZSBhbGwgbm9uLVJBTSBhY2Nl c3NlcyBhcyBkZXZpY2UgYXMgdGhlIGhvc3QgbWF5IGhhdmUgcmVhc29ucyBub3QgdG8Kd2FudCB0 aGlzIChlLmcuIGFjY2Vzc2luZyBTUkFNKS4gWW91ciBmaXJzdCBzdWdnZXN0aW9ucyBhbGxvd3Mg dXMgdG8gZG8KanVzdCB0aGF0LCBzbyBpdCBpcyBwcmVmZXJhYmxlIEkgdGhpbmsuCgpUaGFua3Ms ClF1ZW50aW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K a3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8v bGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682F2C433E0 for ; Tue, 16 Mar 2021 13:00:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D889865057 for ; Tue, 16 Mar 2021 13:00:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D889865057 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NYTSK4yD1KyAig2m6CHFjGAJKHR80WiJtDmOut2E0Uk=; b=m7h3C4CLQBoEhvJI6IErWY0b+ pABoGaOQoqX4f8hqVRl/IVTCwje8g6r93s+wGpzpXXmMAA8uFFQQN92ijwGW5YOUefUl54dzT4scW YlcWzMYaAXkbFE3Q1AVAms0UShrJ23hA8nF1FujIXpfAzDiTf/mZoXForKtUyFAUJrFxer2pgCCfJ pJxE4yeFD6//SwWUq5VdLwSkZ0550Qcb0kRPwxe1sLk/fwA0t5Z8dt/ergDBDBNfLG8IfA8aopA1z 14X9YoqnDLQXP70VGuMbolw8fC6obEhq6T0lAoxcPKJjXhkOURpBbFw2P6RiULeHUgB6+mniy0rkn uoI5Gux6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lM9Hj-000lzB-W7; Tue, 16 Mar 2021 12:58:57 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lM9Cv-000juF-RT for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 12:56:00 +0000 Received: by mail-wr1-x429.google.com with SMTP id j7so7373024wrd.1 for ; Tue, 16 Mar 2021 05:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YhH9qDZ7UYlwG27TDzW+MnA+T1mgb+aVZ+2GGb51p/w=; b=TIM3a2FTxwFa4dUcd5GxP31tl7wKFqCYuHW1RCSsYGdx7PfVWPHK4rzncWHc1Wi7o/ d2c3Bkjb6IsOlZBuk6rn54lnPctO+Kra4AXoGrH+tT7zTPwClbOKbkcQ9wbb+rGcmK3R HUv2leFtOacjysyoAyc9t7BDaMfJ4EoYue76wFoHsTLkgUWeXl3xaHcENikgGzeEy2QY 2AZ211B1x7jPAMLqwIUBhegCNV14sv6beMz36g1/kzF9w2L1N5tTi2BNhRJlm8CoN6hW YRmJP03BcUurDZRpbei0PZIRVONf2SXSbDMfZVUktwxp5jFGb+cUr/XXkKviaSfLxp2l a+7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YhH9qDZ7UYlwG27TDzW+MnA+T1mgb+aVZ+2GGb51p/w=; b=aCiJI2s09CRDIZ9e1lKpvTjlz0nldLinEjRUeilE6jcb/95fOOWWjOgstQggcQjtWQ JtYztlxp46M0rPPPTgVBFYNiNDo+kryYagY2DsYket4bNF/jAd6t0N/MNpNgkpsPvWHt rhtGrFgubIulceqnTrdSWKSXO60Te2F8uoSUjn70XRh53PKey1EIDqn9c30M0dRWi9Hh mHOHkY/lO2jZaBVnj2JmQ+SwRjoCytPNs59QGQvz3Zrg1i7H03DrLR7suWlRnEfBsT0i KVClJAiDVWLvW59mkiOJvP3DK68EieoImgd7WB+Q1JD5VcsqgVul72KRaAf/hbJ7Ie8y wl0Q== X-Gm-Message-State: AOAM531ufFUuu+11HVyYBZ0YRVG/2mDsI9KzOAc7aaYDHoYCUFPkpfSF Pjpbr2aG2NDTJvotEcjiZdCuDA== X-Google-Smtp-Source: ABdhPJxGSb04ZRPkSOl7qX8cOElBY2c0oVdgp7I4wyUE4jKYntg8bGYi4e+uakNSKN8b4ZKHwnBiBg== X-Received: by 2002:adf:fe48:: with SMTP id m8mr4694101wrs.135.1615899235994; Tue, 16 Mar 2021 05:53:55 -0700 (PDT) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id b186sm3074930wmc.44.2021.03.16.05.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 05:53:55 -0700 (PDT) Date: Tue, 16 Mar 2021 12:53:53 +0000 From: Quentin Perret To: Mate Toth-Pal Cc: catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, seanjc@google.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, tabba@google.com, ardb@kernel.org, mark.rutland@arm.com, dbrazdil@google.com Subject: Re: [PATCH v5 33/36] KVM: arm64: Wrap the host with a stage 2 Message-ID: References: <20210315143536.214621-1-qperret@google.com> <20210315143536.214621-34-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_125558_248355_715DDF6E X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlc2RheSAxNiBNYXIgMjAyMSBhdCAxMzoyODo0MiAoKzAxMDApLCBNYXRlIFRvdGgtUGFs IHdyb3RlOgo+IFRlc3RpbmcgdGhlIGxhdGVzdCB2ZXJzaW9uIG9mIHRoZSBwYXRjaHNldCwgd2Ug c2VlbSB0byBoYXZlIGZvdW5kIGFub3RoZXIKPiB0aGluZyByZWxhdGVkIHRvIEZFQVRfUzJGV0Iu CgpBcmdoISBJIHdpc2ggSSBjb3VsZCBwdXQgbXkgaGFuZHMgb24gaGFyZHdhcmUgd2l0aCBGV0Iu IFRoYW5rcyBhZ2FpbiBmb3IKdGhlIHJlcG9ydC4KCj4gVGhpcyBmdW5jdGlvbiBhbHdheXMgc2V0 cyBOb3JtYWwgbWVtb3J5IGluIHRoZSBzdGFnZSAyIHRhYmxlLCBldmVuIGlmIHRoZQo+IGFkZHJl c3MgaW4gc3RhZ2UgMSB3YXMgbWFwcGVkIGFzIGEgZGV2aWNlIG1lbW9yeS4gSG93ZXZlciB3aXRo IHRoZSBjdXJyZW50Cj4gc2V0dGluZ3MgZm9yIG5vcm1hbCBtZW1vcnkgKGkuZS4gTVRfUzJfRldC X05PUk1BTCBiZWluZyBkZWZpbmVkIHRvIDYpCj4gYWNjb3JkaW5nIHRvIHRoZSBhcmNoaXRlY3R1 cmUgKFNlZSBBcm0gQVJNLCAnRDUuNS41IFN0YWdlIDIgbWVtb3J5IHJlZ2lvbgo+IHR5cGUgYW5k IGNhY2hlYWJpbGl0eSBhdHRyaWJ1dGVzIHdoZW4gRkVBVF9TMkZXQiBpcyBpbXBsZW1lbnRlZCcp IHRoZQo+IHJlc3VsdGluZyBhdHRyaWJ1dGVzIHdpbGwgYmUgJ05vcm1hbCBXcml0ZS1CYWNrJyBl dmVuIGlmIHRoZSBzdGFnZSAxIG1hcHBpbmcKPiBzZXRzIGRldmljZSBtZW1vcnkuIEFjY2Vzc2lu ZyBkZXZpY2UgbWVtb3J5IG1hcHBlZCBsaWtlIHRoaXMgY2F1c2VzIGFuCj4gU0Vycm9yIG9uIHNv bWUgcGxhdGZvcm1zIHdpdGggRkVBVF9TMkZXQiBiZWluZyBpbXBsZW1lbnRlZC4KClJpZ2h0LgoK PiBDaGFuZ2luZyB0aGUgdmFsdWUgb2YgTVRfUzJfRldCX05PUk1BTCB0byA3IHdvdWxkIGNoYW5n ZSB0aGlzIGJlaGF2aW9yLCBhbmQKPiB0aGUgcmVzdWx0aW5nIG1lbW9yeSB0eXBlIHdvdWxkIGJl IGRldmljZS4KClNvdW5kcyBsaWtlIHRoZSBjb3JyZWN0IGZpeCBoZXJlIC0tIHNlZSBiZWxvdy4K Cj4gQW5vdGhlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBhZGQgYW4gZWxzZSBicmFuY2ggdG8gdGhl IGxhc3QgJ2lmJyBhYm92ZSBsaWtlCj4gdGhpczoKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02 NC9rdm0vaHlwL252aGUvbWVtX3Byb3RlY3QuYwo+IGIvYXJjaC9hcm02NC9rdm0vaHlwL252aGUv bWVtX3Byb3RlY3QuYwo+IGluZGV4IGZmZmE0MzJjZTNlYi4uNTRlNWQzYjBiMmUxIDEwMDY0NAo+ IC0tLSBhL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL21lbV9wcm90ZWN0LmMKPiArKysgYi9hcmNo L2FybTY0L2t2bS9oeXAvbnZoZS9tZW1fcHJvdGVjdC5jCj4gQEAgLTIxNCw2ICsyMTQsOCBAQCBz dGF0aWMgaW50IGhvc3Rfc3RhZ2UyX2lkbWFwKHU2NCBhZGRyKQo+IAo+IMKgwqDCoMKgwqDCoMKg IGlmIChpc19tZW1vcnkpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByb3QgfD0g S1ZNX1BHVEFCTEVfUFJPVF9YOwo+ICvCoMKgwqDCoMKgwqAgZWxzZQo+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHByb3QgfD0gS1ZNX1BHVEFCTEVfUFJPVF9ERVZJQ0U7Cj4gCj4gwqDC oMKgwqDCoMKgwqAgaHlwX3NwaW5fbG9jaygmaG9zdF9rdm0ubG9jayk7Cj4gwqDCoMKgwqDCoMKg wqAgcmV0ID0ga3ZtX3BndGFibGVfc3RhZ2UyX2ZpbmRfcmFuZ2UoJmhvc3Rfa3ZtLnBndCwgYWRk ciwgcHJvdCwKPiAmcmFuZ2UpOwoKV2hpbGUgdGhpcyB3b3VsZCB3b3JrIGluIHRoaXMgcGFydGlj dWxhciBjYXNlLCBJIGRvbid0IHRoaW5rIHdlIHNob3VsZApmb3JjZSBhbGwgbm9uLVJBTSBhY2Nl c3NlcyBhcyBkZXZpY2UgYXMgdGhlIGhvc3QgbWF5IGhhdmUgcmVhc29ucyBub3QgdG8Kd2FudCB0 aGlzIChlLmcuIGFjY2Vzc2luZyBTUkFNKS4gWW91ciBmaXJzdCBzdWdnZXN0aW9ucyBhbGxvd3Mg dXMgdG8gZG8KanVzdCB0aGF0LCBzbyBpdCBpcyBwcmVmZXJhYmxlIEkgdGhpbmsuCgpUaGFua3Ms ClF1ZW50aW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF854C433E6 for ; Tue, 16 Mar 2021 12:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B67366505B for ; Tue, 16 Mar 2021 12:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232312AbhCPMzQ (ORCPT ); Tue, 16 Mar 2021 08:55:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233647AbhCPMx6 (ORCPT ); Tue, 16 Mar 2021 08:53:58 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71FC1C06174A for ; Tue, 16 Mar 2021 05:53:57 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id x16so7384307wrn.4 for ; Tue, 16 Mar 2021 05:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YhH9qDZ7UYlwG27TDzW+MnA+T1mgb+aVZ+2GGb51p/w=; b=TIM3a2FTxwFa4dUcd5GxP31tl7wKFqCYuHW1RCSsYGdx7PfVWPHK4rzncWHc1Wi7o/ d2c3Bkjb6IsOlZBuk6rn54lnPctO+Kra4AXoGrH+tT7zTPwClbOKbkcQ9wbb+rGcmK3R HUv2leFtOacjysyoAyc9t7BDaMfJ4EoYue76wFoHsTLkgUWeXl3xaHcENikgGzeEy2QY 2AZ211B1x7jPAMLqwIUBhegCNV14sv6beMz36g1/kzF9w2L1N5tTi2BNhRJlm8CoN6hW YRmJP03BcUurDZRpbei0PZIRVONf2SXSbDMfZVUktwxp5jFGb+cUr/XXkKviaSfLxp2l a+7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YhH9qDZ7UYlwG27TDzW+MnA+T1mgb+aVZ+2GGb51p/w=; b=bOBHUXNQFJSnKZTQXIWxj00kvKrZRJ+bDakrcx1n6KOXGHlv66vaT/jrNNMVcWOK0V /dFMPP6b7rXnwtfNiju7zBU1bRIQMkreuS7qx+Uwu58y4k88w6ae5E2l4y1qish3xLbg zSNuxPqZ/5oqNbFWnK+YPuNxijPhIVsjNZppYyGDyMLk0af0fZFHBm1z2rr9y7jBFxBv Q2ekFzTjI8uheQWNl4a2hEelujEMnll1HSYYGH/RSHeEh8YJ+4cuvk7XpiSA8Q44y561 Qde8jrr/fnAu29cDOuDSLdWejDLMexmY+wMWt7ad7PzmZAJKLuVDe9J4/ptCax7bOMyV K1lg== X-Gm-Message-State: AOAM533MxvRuOdagX/AQ97GzymH3SPUexXhbR4Ugd3zzS2VKXydPidU+ goY5ttQpEZSmR107ZMGrJGJ+oQ== X-Google-Smtp-Source: ABdhPJxGSb04ZRPkSOl7qX8cOElBY2c0oVdgp7I4wyUE4jKYntg8bGYi4e+uakNSKN8b4ZKHwnBiBg== X-Received: by 2002:adf:fe48:: with SMTP id m8mr4694101wrs.135.1615899235994; Tue, 16 Mar 2021 05:53:55 -0700 (PDT) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id b186sm3074930wmc.44.2021.03.16.05.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 05:53:55 -0700 (PDT) Date: Tue, 16 Mar 2021 12:53:53 +0000 From: Quentin Perret To: Mate Toth-Pal Cc: catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, seanjc@google.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, tabba@google.com, ardb@kernel.org, mark.rutland@arm.com, dbrazdil@google.com Subject: Re: [PATCH v5 33/36] KVM: arm64: Wrap the host with a stage 2 Message-ID: References: <20210315143536.214621-1-qperret@google.com> <20210315143536.214621-34-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 16 Mar 2021 at 13:28:42 (+0100), Mate Toth-Pal wrote: > Testing the latest version of the patchset, we seem to have found another > thing related to FEAT_S2FWB. Argh! I wish I could put my hands on hardware with FWB. Thanks again for the report. > This function always sets Normal memory in the stage 2 table, even if the > address in stage 1 was mapped as a device memory. However with the current > settings for normal memory (i.e. MT_S2_FWB_NORMAL being defined to 6) > according to the architecture (See Arm ARM, 'D5.5.5 Stage 2 memory region > type and cacheability attributes when FEAT_S2FWB is implemented') the > resulting attributes will be 'Normal Write-Back' even if the stage 1 mapping > sets device memory. Accessing device memory mapped like this causes an > SError on some platforms with FEAT_S2FWB being implemented. Right. > Changing the value of MT_S2_FWB_NORMAL to 7 would change this behavior, and > the resulting memory type would be device. Sounds like the correct fix here -- see below. > Another solution would be to add an else branch to the last 'if' above like > this: > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index fffa432ce3eb..54e5d3b0b2e1 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -214,6 +214,8 @@ static int host_stage2_idmap(u64 addr) > >         if (is_memory) >                 prot |= KVM_PGTABLE_PROT_X; > +       else > +               prot |= KVM_PGTABLE_PROT_DEVICE; > >         hyp_spin_lock(&host_kvm.lock); >         ret = kvm_pgtable_stage2_find_range(&host_kvm.pgt, addr, prot, > &range); While this would work in this particular case, I don't think we should force all non-RAM accesses as device as the host may have reasons not to want this (e.g. accessing SRAM). Your first suggestions allows us to do just that, so it is preferable I think. Thanks, Quentin