All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mihai Carabas <mihai.carabas@oracle.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
	bobo.shaobowang@huawei.com, rdunlap@infradead.org
Subject: Re: [PATCH v5 1/3] misc/pvpanic: split-up generic and platform dependent code
Date: Tue, 16 Mar 2021 17:44:57 +0100	[thread overview]
Message-ID: <YFDgictc4oFuJYc2@kroah.com> (raw)
In-Reply-To: <1615897229-4055-2-git-send-email-mihai.carabas@oracle.com>

On Tue, Mar 16, 2021 at 02:20:27PM +0200, Mihai Carabas wrote:
> +#ifdef pr_fmt
> +#undef pr_fmt
> +#endif
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

This isn't even needed given you do not have any pr_* calls in this
code.  As you shouldn't this is driver stuff, you should always use the
dev_* calls instead.

But you can delete that later, this is fine for now.  However generally
you do not set this value in a .h file, but rather in the individual .c
files if you really need it.

thanks,

greg k-h

  reply	other threads:[~2021-03-16 16:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 12:20 [PATCH v5] add support for pci in the pvpanic driver Mihai Carabas
2021-03-16 12:20 ` [PATCH v5 1/3] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-03-16 16:44   ` Greg KH [this message]
2021-03-16 12:20 ` [PATCH v5 2/3] misc/pvpanic: probe multiple instances Mihai Carabas
2021-03-16 16:46   ` Greg KH
2021-03-16 12:20 ` [PATCH v5 3/3] misc/pvpanic: add PCI driver Mihai Carabas
2021-03-16 16:48   ` Greg KH
2021-03-16 17:08     ` Mihai Carabas
2021-03-16 17:29       ` Greg KH
2021-03-16 18:02         ` Mihai Carabas
2021-03-16 18:16           ` Greg KH
2021-03-17  0:02   ` kernel test robot
2021-03-17  0:02     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFDgictc4oFuJYc2@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=bobo.shaobowang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.carabas@oracle.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.