From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: staging: rtl8723bs: remove unused code blocks completed?
Date: Wed, 17 Mar 2021 11:02:13 +0100 [thread overview]
Message-ID: <YFHTpb6oSarirQJv@kroah.com> (raw)
In-Reply-To: <20210317095932.GA2308@agape.jhs>
On Wed, Mar 17, 2021 at 10:59:32AM +0100, Fabio Aiuto wrote:
> Hi,
>
> I'm trying to search other unused code blocks:
>
> grep -r '^\(#ifdef \|#if defined(\|#ifndef \)CONFIG_' drivers/staging/rtl8723bs/
>
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:#if defined(CONFIG_PM)
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:#if defined(CONFIG_WEXT_PRIV)
> drivers/staging/rtl8723bs/include/drv_conf.h:#ifndef CONFIG_RTW_HIQ_FILTER
> drivers/staging/rtl8723bs/include/autoconf.h:#ifndef CONFIG_WIRELESS_EXT
>
> all blocks left are checked by existing defines.
> Could we apply this?
Sure, looks good, submit this as a real patch with this information in
the changelog and I"ll be glad to take it.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-17 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:59 staging: rtl8723bs: remove unused code blocks completed? Fabio Aiuto
2021-03-17 10:02 ` Greg KH [this message]
2021-03-17 10:51 ` [PATCH] staging: rtl8723bs: remove unused code blocks completed Fabio Aiuto
-- strict thread matches above, loose matches on Subject: below --
2021-03-17 9:58 staging: rtl8723bs: remove unused code blocks completed? Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFHTpb6oSarirQJv@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fabioaiuto83@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.