From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: jason.wessel@windriver.com, dianders@chromium.org,
kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c
Date: Wed, 17 Mar 2021 16:11:17 +0530 [thread overview]
Message-ID: <YFHczQgtyISU8ApU@ArchLinux> (raw)
In-Reply-To: <20210317103638.sw4wqq4p4hg7dhco@maple.lan>
[-- Attachment #1: Type: text/plain, Size: 1768 bytes --]
On 10:36 Wed 17 Mar 2021, Daniel Thompson wrote:
>On Wed, Mar 17, 2021 at 02:40:22PM +0530, Bhaskar Chowdhury wrote:
>>
>> s/'O'utput/'Output/
>> s/overwitten/overwritten/
>> s/procesing/processing/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> kernel/debug/gdbstub.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c
>> index e149a0ac9e9e..5c96590725f1 100644
>> --- a/kernel/debug/gdbstub.c
>> +++ b/kernel/debug/gdbstub.c
>> @@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
>> if (len == 0)
>> len = strlen(s);
>>
>> - /* 'O'utput */
>> + /* 'Output */
>
>This is not a typo.
>
>It is showing that the 'O' being writing into the message buffer is a
>mnemonic and describing what it expands to.
>
>Other changes look good, please can you resend with this one removed?
>
>
Sure, thanks Daniel....V2 on the way...
>Daniel.
>
>
>> gdbmsgbuf[0] = 'O';
>>
>> /* Fill and send buffers... */
>> @@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
>> /*
>> * Copy the binary array pointed to by buf into mem. Fix $, #, and
>> * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
>> - * The input buf is overwitten with the result to write to mem.
>> + * The input buf is overwritten with the result to write to mem.
>> */
>> static int kgdb_ebin2mem(char *buf, char *mem, int count)
>> {
>> @@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
>> }
>>
>> /*
>> - * This function performs all gdbserial command procesing
>> + * This function performs all gdbserial command processing
>> */
>> int gdb_serial_stub(struct kgdb_state *ks)
>> {
>> --
>> 2.30.2
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-17 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:10 [PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c Bhaskar Chowdhury
2021-03-17 10:36 ` Daniel Thompson
2021-03-17 10:41 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFHczQgtyISU8ApU@ArchLinux \
--to=unixbhaskar@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.