All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] pec: Convert to the new API
Date: Wed, 17 Mar 2021 12:47:21 +0100	[thread overview]
Message-ID: <YFHsSWLeaqwdAWzZ@pevik> (raw)
In-Reply-To: <87117f6f-58e7-8b68-38c3-be5b080e86b6@jv-coder.de>

Hi J?rg,

> Hi Petr,

> On 3/17/2021 10:34 AM, Petr Vorel wrote:
> > BTW: would it make sense to rename runtest/connectors to runtest/netlink
> > and move code from testcases/kernel/connectors/ to testcases/kernel/netlink/?
> Maybe kernel/netlink/connector/. Connector is an abstraction on top of
+1

> netlink with a slightly
> different interface than pure netlink (eg. cn_msg instead of nlmsghdr).
> There are only very few other modules, that use this interface at the moment
> (MS HyperV, MD,? uvesafb? and dallas' 1-wire).
I'd still put it into netlink and try to put there more general netlink
subsystem tests. My objection is that runtest/connectors has only single test
and connectors is very generic name.

> The question is: Is the interface the correct think to categorize by? If the
> interface (i.e. netlink) is used for categorization, then some of the crypto
> tests should also be in this netlink category.
Thus maybe add some of relevant tests also into runtest/netlink? We shave some
kind of duplicity (see runtest/cve, it contains some tests which are also in
runtest/syscalls). That would also justify creating runtest/netlink (because
having just single test for legacy connector interface in runtest/netlink does
not sound good to me).

Kind regards,
Petr

> J?rg

  reply	other threads:[~2021-03-17 11:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15  9:28 [LTP] [PATCH 1/2] pec: Convert to the new API Joerg Vehlow
2021-03-15  9:28 ` [LTP] [PATCH 2/2] pec: Fix multiple event test Joerg Vehlow
2021-03-29 18:08   ` Petr Vorel
2021-03-29 18:43   ` Petr Vorel
2021-04-15  9:06     ` Joerg Vehlow
2021-03-30  8:30   ` Petr Vorel
2021-04-01 11:30     ` Petr Vorel
2021-03-17  9:34 ` [LTP] [PATCH 1/2] pec: Convert to the new API Petr Vorel
2021-03-17 10:05   ` Joerg Vehlow
2021-03-17 11:47     ` Petr Vorel [this message]
2021-03-29 17:56 ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFHsSWLeaqwdAWzZ@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.