From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v5 0/2] gpio: sch: Interrupt support
Date: Thu, 18 Mar 2021 14:26:27 +0200 [thread overview]
Message-ID: <YFNG8+sdIj6Orbjq@smile.fi.intel.com> (raw)
In-Reply-To: <20210317151928.41544-1-andriy.shevchenko@linux.intel.com>
On Wed, Mar 17, 2021 at 05:19:26PM +0200, Andy Shevchenko wrote:
> The series adds event support to the Intel GPIO SCH driver. The hardware
> routes all events through GPE0 GPIO event.
>
> I validated this on Intel Minnowboard (v1).
>
> If somebody has different hardware with the same GPIO controller, I would
> appreciate additional testing.
I've applied this to my review and testing queue, thanks!
> Changes in v5:
> - added missed IRQ acknowledge callback (hence kernel Oops)
> - rewrite patch 2 completely from SCI to GPE hook
>
> Changes in v4 (https://lore.kernel.org/linux-gpio/20210316162613.87710-1-andriy.shevchenko@linux.intel.com/T/#u):
> - turned to GPIO core infrastructure of IRQ chip instantiation (Linus)
> - converted IRQ callbacks to use better APIs
> - use handle_bad_irq() as default handler and now I know why, see
> eb441337c714 ("gpio: pca953x: Set IRQ type when handle Intel Galileo Gen 2")
> for the real example what happens if it's preset to something meaningful
> - fixed remove stage (we have to remove SCI handler, which wasn't done in v3)
>
> Changes in v3 (https://lore.kernel.org/linux-gpio/cover.1574277614.git.jan.kiszka@siemens.com/T/#u):
> - split-up of the irq enabling patch as requested by Andy
>
> Andy Shevchenko (1):
> gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events
>
> Jan Kiszka (1):
> gpio: sch: Add edge event support
>
> drivers/gpio/gpio-sch.c | 196 ++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 188 insertions(+), 8 deletions(-)
>
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-03-18 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 15:19 [PATCH v5 0/2] gpio: sch: Interrupt support Andy Shevchenko
2021-03-17 15:19 ` [PATCH v5 1/2] gpio: sch: Add edge event support Andy Shevchenko
2021-03-25 8:13 ` Linus Walleij
2021-03-25 11:33 ` Andy Shevchenko
2021-03-17 15:19 ` [PATCH v5 2/2] gpio: sch: Hook into ACPI GPE handler to catch GPIO edge events Andy Shevchenko
2021-03-25 8:16 ` Linus Walleij
2021-03-18 12:26 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFNG8+sdIj6Orbjq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.