All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org,
	shakeelb@google.com, vdavydov.dev@gmail.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	duanxiongchun@bytedance.com
Subject: Re: [PATCH v4 3/5] mm: memcontrol: change ug->dummy_page only if memcg changed
Date: Thu, 18 Mar 2021 11:11:06 -0400	[thread overview]
Message-ID: <YFNtim0E1536F7ya@cmpxchg.org> (raw)
In-Reply-To: <20210318110658.60892-4-songmuchun@bytedance.com>

On Thu, Mar 18, 2021 at 07:06:56PM +0800, Muchun Song wrote:
> Just like assignment to ug->memcg, we only need to update ug->dummy_page
> if memcg changed. So move it to there. This is a very small optimization.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>


  reply	other threads:[~2021-03-18 15:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 11:06 [PATCH v4 0/5] Use obj_cgroup APIs to charge kmem pages Muchun Song
2021-03-18 11:06 ` [PATCH v4 1/5] mm: memcontrol: introduce obj_cgroup_{un}charge_pages Muchun Song
2021-03-18 11:06 ` [PATCH v4 2/5] mm: memcontrol: directly access page->memcg_data in mm/page_alloc.c Muchun Song
2021-03-18 15:09   ` Johannes Weiner
2021-03-19  1:00   ` Shakeel Butt
2021-03-18 11:06 ` [PATCH v4 3/5] mm: memcontrol: change ug->dummy_page only if memcg changed Muchun Song
2021-03-18 15:11   ` Johannes Weiner [this message]
2021-03-19  1:22   ` Shakeel Butt
2021-03-18 11:06 ` [PATCH v4 4/5] mm: memcontrol: use obj_cgroup APIs to charge kmem pages Muchun Song
2021-03-18 15:23   ` Johannes Weiner
2021-03-19  3:39   ` Shakeel Butt
2021-03-19  4:05     ` [External] " Muchun Song
2021-03-19 13:59       ` Shakeel Butt
2021-03-19 15:45         ` Muchun Song
2021-03-18 11:06 ` [PATCH v4 5/5] mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFNtim0E1536F7ya@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=duanxiongchun@bytedance.com \
    --cc=guro@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.