From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Michael Rolnik" <mrolnik@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: of AVR target page size
Date: Thu, 18 Mar 2021 20:05:00 +0000 [thread overview]
Message-ID: <YFOybOQAk6IXCL0R@work-vm> (raw)
In-Reply-To: <CAFEAcA8+FfNaQ+26cSKYP8X05F-hqZ+0CxF7cS0hj=AW2M6O6g@mail.gmail.com>
* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Thu, 18 Mar 2021 at 10:45, Dr. David Alan Gilbert
> <dgilbert@redhat.com> wrote:
> >
> > * Peter Maydell (peter.maydell@linaro.org) wrote:
> > > Also, what does the
> > > /* 0x80 is reserved in migration.h start with 0x100 next */
> > > comment refer to? migration.h has no instances of "RAM_SAVE"
> > > or 0x80 or 1 << 7...
> >
> > It looks like it got moved to qemu-file.h a few years ago
> > as RAM_SAVE_FLAG_HOOK.
>
> Could we put the define of RAM_SAVE_FLAG_HOOK in migration.h
> with all the other RAM_SAVE_FLAG defines ? It looks like the two
> places that use it already include migration.h...
Do you mean move the rest of the RAM_SAVE_FLAG_* from migration/ram.c
into migration.h?
We could do - although they're never used by anything else.
Dave
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-03-18 20:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:14 of AVR target page size Dr. David Alan Gilbert
2021-03-17 21:32 ` Michael Rolnik
2021-03-18 9:55 ` Dr. David Alan Gilbert
2021-03-18 10:15 ` Michael Rolnik
2021-03-18 10:21 ` Dr. David Alan Gilbert
2021-03-17 22:33 ` Peter Maydell
2021-03-18 7:37 ` Michael Rolnik
2021-03-18 10:18 ` Dr. David Alan Gilbert
2021-03-18 10:21 ` Peter Maydell
2021-03-18 10:25 ` Dr. David Alan Gilbert
2021-03-18 10:34 ` Peter Maydell
2021-03-18 10:45 ` Dr. David Alan Gilbert
2021-03-18 11:03 ` Michael Rolnik
2021-03-18 20:03 ` Dr. David Alan Gilbert
2021-03-18 11:12 ` Peter Maydell
2021-03-18 20:05 ` Dr. David Alan Gilbert [this message]
2021-03-18 20:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFOybOQAk6IXCL0R@work-vm \
--to=dgilbert@redhat.com \
--cc=mrolnik@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.