From: Andrew Lunn <andrew@lunn.ch>
To: Jiri Bohac <jbohac@suse.cz>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH] net: check all name nodes in __dev_alloc_name
Date: Thu, 18 Mar 2021 22:40:35 +0100 [thread overview]
Message-ID: <YFPI0ws/GrEa24SN@lunn.ch> (raw)
In-Reply-To: <20210318034253.w4w2p3kvi4m6vqp5@dwarf.suse.cz>
On Thu, Mar 18, 2021 at 04:42:53AM +0100, Jiri Bohac wrote:
> __dev_alloc_name(), when supplied with a name containing '%d',
> will search for the first available device number to generate a
> unique device name.
>
> Since commit ff92741270bf8b6e78aa885f166b68c7a67ab13a ("net:
> introduce name_node struct to be used in hashlist") network
> devices may have alternate names. __dev_alloc_name() does take
Should this be "does not take"
> these alternate names into account, possibly generating a name
> that is already taken and failing with -ENFILE as a result.
Andrew
next prev parent reply other threads:[~2021-03-18 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 3:42 [PATCH] net: check all name nodes in __dev_alloc_name Jiri Bohac
2021-03-18 4:11 ` Stephen Hemminger
2021-03-18 9:06 ` Jiri Bohac
2021-03-18 18:28 ` Stephen Hemminger
2021-03-18 7:43 ` Jiri Pirko
2021-03-18 21:40 ` Andrew Lunn [this message]
2021-03-18 21:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFPI0ws/GrEa24SN@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jbohac@suse.cz \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.