All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: helgaas@kernel.org, linux-pci@vger.kernel.org,
	alex.williamson@redhat.com, prime.zeng@huawei.com,
	linuxarm@huawei.dom, Amey Narkhede <ameynarkhede03@gmail.com>
Subject: Re: [PATCH v2] PCI: Factor functions of PCI function reset
Date: Fri, 19 Mar 2021 18:09:06 +0100	[thread overview]
Message-ID: <YFTaskobyoEzLkeE@rocinante> (raw)
In-Reply-To: <1616145918-31356-1-git-send-email-yangyicong@hisilicon.com>

[+cc Amey as he is workingo on a larger refactor of the reset functions]

Hi,

> Previously we used pci_probe_reset_function() to probe whether a function
> can be reset and use __pci_reset_function_locked() to perform a function
> reset. These two functions have lots of common lines.
> 
> Factor the two functions and reduce the redundancy.
[...]

I wanted to bring the following thread to your attention as you are
working on the same code that it's being talked about there in the
on-going conversation, see:

  https://lore.kernel.org/linux-pci/20210312173452.3855-1-ameynarkhede03@gmail.com/

I wonder if there would be some overlap, etc.

Krzysztof

  reply	other threads:[~2021-03-19 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  9:25 [PATCH v2] PCI: Factor functions of PCI function reset Yicong Yang
2021-03-19 17:09 ` Krzysztof Wilczyński [this message]
2021-03-22 11:56   ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFTaskobyoEzLkeE@rocinante \
    --to=kw@linux.com \
    --cc=alex.williamson@redhat.com \
    --cc=ameynarkhede03@gmail.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@huawei.dom \
    --cc=prime.zeng@huawei.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.