From: Andrew Lunn <andrew@lunn.ch>
To: Leon Romanovsky <leon@kernel.org>
Cc: Alex Elder <elder@linaro.org>,
davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] net: ipa: introduce ipa_assert()
Date: Fri, 19 Mar 2021 19:20:35 +0100 [thread overview]
Message-ID: <YFTrc4wGyZ5142Es@lunn.ch> (raw)
In-Reply-To: <YFQurZjWYaolHGvR@unreal>
> It will be much better for everyone if you don't obfuscate existing
> kernel primitives and don't hide constant vs. dynamic expressions.
>
> So any random kernel developer will be able to change the code without
> investing too much time to understand this custom logic.
>
> And constant expressions are checked with BUILD_BUG_ON().
>
> If you still feel need to provide assertion like this, it should be done
> in general code.
+1
Andrew
next prev parent reply other threads:[~2021-03-19 18:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 4:29 [PATCH net-next 0/4] net: ipa: fix validation Alex Elder
2021-03-19 4:29 ` [PATCH net-next 1/4] net: ipa: fix init header command validation Alex Elder
2021-03-19 4:29 ` [PATCH net-next 2/4] net: ipa: fix IPA validation Alex Elder
2021-03-19 4:29 ` [PATCH net-next 3/4] net: ipa: introduce ipa_assert() Alex Elder
2021-03-19 4:55 ` Leon Romanovsky
2021-03-19 12:38 ` Alex Elder
2021-03-19 15:32 ` Leon Romanovsky
2021-03-19 16:01 ` Alex Elder
2021-03-19 18:20 ` Andrew Lunn [this message]
2021-03-19 4:29 ` [PATCH net-next 4/4] net: ipa: activate some commented assertions Alex Elder
2021-03-19 5:00 ` Leon Romanovsky
2021-03-19 12:40 ` Alex Elder
2021-03-19 15:17 ` Leon Romanovsky
2021-03-19 15:32 ` Alex Elder
2021-03-19 18:32 ` Andrew Lunn
2021-03-19 21:18 ` Alex Elder
2021-03-19 21:30 ` Andrew Lunn
2021-03-20 13:24 ` [PATCH net-next 0/4] net: ipa: fix validation Alex Elder
2021-03-20 14:23 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFTrc4wGyZ5142Es@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.