From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
alistair23@gmail.com
Subject: Re: [PATCH v3 4/9] Input: wacom_i2c - Add touchscren properties
Date: Sun, 21 Mar 2021 13:08:20 -0700 [thread overview]
Message-ID: <YFentDIVXUmUT9Ya@google.com> (raw)
In-Reply-To: <20210321141049.148-5-alistair@alistair23.me>
On Sun, Mar 21, 2021 at 10:10:44AM -0400, Alistair Francis wrote:
> Connect touchscreen properties to the wacom_i2c.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> drivers/input/touchscreen/wacom_i2c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/touchscreen/wacom_i2c.c b/drivers/input/touchscreen/wacom_i2c.c
> index fc0bf583d33b..9b2ed0463d09 100644
> --- a/drivers/input/touchscreen/wacom_i2c.c
> +++ b/drivers/input/touchscreen/wacom_i2c.c
> @@ -11,6 +11,7 @@
> #include <linux/i2c.h>
> #include <linux/slab.h>
> #include <linux/irq.h>
> +#include <linux/input/touchscreen.h>
> #include <linux/interrupt.h>
> #include <linux/of.h>
> #include <asm/unaligned.h>
> @@ -33,6 +34,7 @@ struct wacom_features {
> struct wacom_i2c {
> struct i2c_client *client;
> struct input_dev *input;
> + struct touchscreen_properties props;
> u8 data[WACOM_QUERY_SIZE];
> bool prox;
> int tool;
> @@ -188,6 +190,7 @@ static int wacom_i2c_probe(struct i2c_client *client,
> __set_bit(BTN_STYLUS2, input->keybit);
> __set_bit(BTN_TOUCH, input->keybit);
>
> + touchscreen_parse_properties(input, true, &wac_i2c->props);
> input_set_abs_params(input, ABS_X, 0, features.x_max, 0, 0);
> input_set_abs_params(input, ABS_Y, 0, features.y_max, 0, 0);
> input_set_abs_params(input, ABS_PRESSURE,
Please also use touchscreen_report_pos() so flipping and swapping of
axes also works.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-03-21 20:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 14:10 [PATCH v3 0/9] Add Wacom I2C support to rM2 Alistair Francis
2021-03-21 14:10 ` [PATCH v3 1/9] dt-bindings: Add Wacom to vendor bindings Alistair Francis
2021-03-21 14:10 ` [PATCH v3 2/9] dt-bindings: touchscreen: Initial commit of wacom,generic Alistair Francis
2021-03-21 14:10 ` [PATCH v3 3/9] Input: wacom_i2c - Add device tree support to wacom_i2c Alistair Francis
2021-03-21 20:06 ` Dmitry Torokhov
2021-03-21 14:10 ` [PATCH v3 4/9] Input: wacom_i2c - Add touchscren properties Alistair Francis
2021-03-21 20:08 ` Dmitry Torokhov [this message]
2021-03-21 14:10 ` [PATCH v3 5/9] Input: wacom_i2c - Add support for distance and tilt x/y Alistair Francis
2021-03-21 14:10 ` [PATCH v3 6/9] Input: wacom_i2c - Clean up the query device fields Alistair Francis
2021-03-21 20:10 ` Dmitry Torokhov
2021-03-21 14:10 ` [PATCH v3 7/9] Input: wacom_i2c - Add support for vdd regulator Alistair Francis
2021-03-21 21:43 ` Dmitry Torokhov
2021-03-21 14:10 ` [PATCH v3 8/9] ARM: imx_v6_v7_defconfig: Enable Wacom I2C Alistair Francis
2021-03-21 14:10 ` [PATCH v3 9/9] ARM: dts: imx7d: remarkable2: add wacom digitizer device Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFentDIVXUmUT9Ya@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.