From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: Fix typos in comments
Date: Mon, 22 Mar 2021 09:28:52 +0530 [thread overview]
Message-ID: <YFgV/Np4ps8zFG6j@ArchLinux> (raw)
In-Reply-To: <2cc83cd7-6fd2-2b4f-b03a-5e1a384aa137@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]
On 20:52 Sun 21 Mar 2021, Randy Dunlap wrote:
>On 3/21/21 8:44 PM, Matthew Wilcox wrote:
>> On Mon, Mar 22, 2021 at 03:51:52AM +0100, Ingo Molnar wrote:
>>> +++ b/mm/huge_memory.c
>>> @@ -1794,7 +1794,7 @@ bool move_huge_pmd(struct vm_area_struct *vma, unsigned long old_addr,
>>> /*
>>> * Returns
>>> * - 0 if PMD could not be locked
>>> - * - 1 if PMD was locked but protections unchange and TLB flush unnecessary
>>> + * - 1 if PMD was locked but protections unchanged and TLB flush unnecessary
>>> * - HPAGE_PMD_NR is protections changed and TLB flush necessary
>>
>> s/is/if/
>>
>>> @@ -5306,7 +5306,7 @@ void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
>>>
>>> /*
>>> * vma need span at least one aligned PUD size and the start,end range
>>> - * must at least partialy within it.
>>> + * must at least partially within it.
>>
>> * vma needs to span at least one aligned PUD size, and the range
>> * must be at least partially within in.
>>
>>> /*
>>> * swapon tell device that all the old swap contents can be discarded,
>>> - * to allow the swap device to optimize its wear-levelling.
>>> + * to allow the swap device to optimize its wear-leveling.
>>> */
>>
>> Levelling is british english, leveling is american english. we don't
>> usually "correct" one into the other.
>
>How about "labelled" (from mm/kasan/shadow.c):
>
Not sure , "levelling" and "labelling" is the same thing...I think all of us
missed the context ...isn't that dictated by the context(soruce code,
effecets) ...
>@@ -384,7 +384,7 @@ static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr,
> * How does this work?
> * -------------------
> *
>- * We have a region that is page aligned, labelled as A.
>+ * We have a region that is page aligned, labeled as A.
> * That might not map onto the shadow in a way that is page-aligned:
>
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-22 3:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 2:51 [PATCH] mm: Fix typos in comments Ingo Molnar
2021-03-22 3:44 ` Matthew Wilcox
2021-03-22 3:52 ` Randy Dunlap
2021-03-22 3:58 ` Bhaskar Chowdhury [this message]
2021-03-22 20:52 ` [PATCH, -v2] " Ingo Molnar
2021-03-22 4:01 ` [PATCH] " Randy Dunlap
2021-03-22 20:50 ` Ingo Molnar
2021-03-22 21:02 ` Randy Dunlap
2021-03-22 21:26 ` [PATCH, -v3] " Ingo Molnar
2021-03-28 21:52 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2021-05-09 6:26 [PATCH] mm: fix " Hyeonggon Yoo
2022-03-18 10:37 Julia Lawall
2022-03-18 11:07 ` Joe Perches
2022-03-18 11:15 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFgV/Np4ps8zFG6j@ArchLinux \
--to=unixbhaskar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=riel@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.