From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: robh+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Input: iqs5xx - make reset GPIO optional
Date: Mon, 22 Mar 2021 20:16:23 -0700 [thread overview]
Message-ID: <YFldhzhYiuqLKdNq@google.com> (raw)
In-Reply-To: <20210323021006.367-1-jeff@labundy.com>
On Mon, Mar 22, 2021 at 09:10:05PM -0500, Jeff LaBundy wrote:
> The device's hardware reset pin is only required if the platform
> must be able to update the device's firmware.
>
> As such, demote the reset GPIO to optional in support of devices
> that ship with pre-programmed firmware and don't route the reset
> pin back to the SoC.
>
> In that case, the 'fw_file' attribute is hidden because there is
> no way to open the bootloader. The logic is extended to the case
> in which the device does not advertise bootloader support in the
> first place.
>
> Last but not least, remove the hardware reset performed at probe
> because there is no reason to reset the device manually. A power
> on reset function already ensures a clean reset at start-up.
>
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-03-23 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 2:10 [PATCH v3 1/2] Input: iqs5xx - make reset GPIO optional Jeff LaBundy
2021-03-23 2:10 ` [PATCH v3 2/2] dt-bindings: input: iqs5xx: Convert to YAML Jeff LaBundy
2021-03-23 3:17 ` Dmitry Torokhov
2021-03-23 3:16 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFldhzhYiuqLKdNq@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.