From: Greg KH <gregkh@linuxfoundation.org>
To: Mihai Carabas <mihai.carabas@oracle.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
bobo.shaobowang@huawei.com, rdunlap@infradead.org
Subject: Re: [PATCH v7 1/3] misc/pvpanic: split-up generic and platform dependent code
Date: Tue, 23 Mar 2021 16:50:04 +0100 [thread overview]
Message-ID: <YFoOLON5W2hiOY4T@kroah.com> (raw)
In-Reply-To: <1616507978-15661-2-git-send-email-mihai.carabas@oracle.com>
On Tue, Mar 23, 2021 at 03:59:36PM +0200, Mihai Carabas wrote:
> Split-up generic and platform dependent code in order to be able to re-use
> generic event handling code in pvpanic PCI device driver in the next patches.
>
> The code from pvpanic.c was split in two new files:
> - pvpanic.c: generic code that handles pvpanic events
> - pvpanic-mmio.c: platform/bus dependent code
>
> Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
> ---
> drivers/misc/Kconfig | 9 +-
> drivers/misc/Makefile | 2 +-
> drivers/misc/pvpanic.c | 161 ------------------------------------
> drivers/misc/pvpanic/Kconfig | 19 +++++
> drivers/misc/pvpanic/Makefile | 7 ++
> drivers/misc/pvpanic/pvpanic-mmio.c | 135 ++++++++++++++++++++++++++++++
> drivers/misc/pvpanic/pvpanic.c | 77 +++++++++++++++++
> drivers/misc/pvpanic/pvpanic.h | 15 ++++
> 8 files changed, 255 insertions(+), 170 deletions(-)
> delete mode 100644 drivers/misc/pvpanic.c
> create mode 100644 drivers/misc/pvpanic/Kconfig
> create mode 100644 drivers/misc/pvpanic/Makefile
> create mode 100644 drivers/misc/pvpanic/pvpanic-mmio.c
> create mode 100644 drivers/misc/pvpanic/pvpanic.c
> create mode 100644 drivers/misc/pvpanic/pvpanic.h
With just this commit applied, I get the following build warnings:
drivers/misc/pvpanic/pvpanic-mmio.c:26:22: warning: ‘base’ defined but not used [-Wunused-variable]
26 | static void __iomem *base;
| ^~~~
ERROR: modpost: missing MODULE_LICENSE() in drivers/misc/pvpanic/pvpanic.o
Remember, each patch needs to work properly and not cause any build
failures or warnings to be added to the tree.
I suggest getting someone else at Oracle to review and test your
patchset before submitting it again so as I don't have to be the ones
finding these types of errors :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-23 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:59 [PATCH v7] add support for pci in the pvpanic driver Mihai Carabas
2021-03-23 13:59 ` [PATCH v7 1/3] misc/pvpanic: split-up generic and platform dependent code Mihai Carabas
2021-03-23 15:50 ` Greg KH [this message]
2021-03-23 13:59 ` [PATCH v7 2/3] misc/pvpanic: probe multiple instances Mihai Carabas
2021-03-23 13:59 ` [PATCH v7 3/3] misc/pvpanic: add PCI driver Mihai Carabas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFoOLON5W2hiOY4T@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bobo.shaobowang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.