Re: [PATCH v1 for-rc] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server

[Leon Romanovsky <leon@kernel.org>]

On Mon, Mar 22, 2021 at 09:52:09PM +0530, Potnuri Bharat Teja wrote:
> Not setting ipv6 bit while destroying ipv6 listening servers may result in
> potential fatal adapter errors due to lookup engine memory hash errors.
> Therefore always set ipv6 field while destroying ipv6 listening servers.
> 
> Fixes: 830662f6f032 ("RDMA/cxgb4: Add support for active and passive open connection with IPv6 address")
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
> Changes since v0:
> - modified commit description to inform the severity of patch.
> ---
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 8769e7aa097f..76faba892f00 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -3599,8 +3599,9 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog)
>  
>  int c4iw_destroy_listen(struct iw_cm_id *cm_id)
>  {
> -	int err;
>  	struct c4iw_listen_ep *ep = to_listen_ep(cm_id);
> +	bool ipv6 = false;

You don't need extra variable, simply pass true/false.

Thanks