From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
wsa@kernel.org, linux-i2c@vger.kernel.org, treding@nvidia.com,
jarkko.nikula@linux.intel.com, rmk+kernel@armlinux.org.uk,
song.bao.hua@hisilicon.com, john.garry@huawei.com,
prime.zeng@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH v3 1/3] i2c: core: add managed function for adding i2c adapters
Date: Wed, 24 Mar 2021 13:06:08 +0200 [thread overview]
Message-ID: <YFsdIN6kuIo7sxMm@smile.fi.intel.com> (raw)
In-Reply-To: <23efcf01-5d04-242e-8574-bb9a5ef5face@hisilicon.com>
On Wed, Mar 24, 2021 at 04:29:26PM +0800, Yicong Yang wrote:
> On 2021/3/23 0:45, Dmitry Osipenko wrote:
> > 22.03.2021 14:10, Yicong Yang пишет:
...
> >> +EXPORT_SYMBOL(devm_i2c_add_adapter);
> >
> > EXPORT_SYMBOL_GPL
>
> considering i2c_add_adapter exported with no GPL, i think the variant should
> keep the same.
Nope. You should follow other devm_*() APIs. Hint: they are using struct device
which is GPL.
Please, fix.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-24 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 11:10 [PATCH v3 0/3] Add support for HiSilicon I2C controller Yicong Yang
2021-03-22 11:10 ` [PATCH v3 1/3] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-03-22 16:35 ` Andy Shevchenko
2021-03-24 8:26 ` Yicong Yang
2021-03-24 11:05 ` Andy Shevchenko
2021-03-22 16:45 ` Dmitry Osipenko
2021-03-24 8:29 ` Yicong Yang
2021-03-24 11:06 ` Andy Shevchenko [this message]
2021-03-22 11:10 ` [PATCH v3 2/3] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-03-22 15:21 ` Dmitry Osipenko
2021-03-24 9:30 ` Yicong Yang
2021-03-24 12:26 ` Dmitry Osipenko
2021-03-22 16:59 ` Andy Shevchenko
2021-03-24 10:07 ` Yicong Yang
2021-03-24 11:15 ` Andy Shevchenko
2021-03-22 17:04 ` Andy Shevchenko
2021-03-24 10:21 ` Yicong Yang
2021-03-24 11:16 ` Andy Shevchenko
2021-03-22 11:10 ` [PATCH v3 3/3] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFsdIN6kuIo7sxMm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.