From: Greg KH <gregkh@linuxfoundation.org>
To: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument
Date: Wed, 7 Apr 2021 10:34:58 +0200 [thread overview]
Message-ID: <YG1usolTNEOfDqXh@kroah.com> (raw)
In-Reply-To: <4d7ebe9c-8ebc-2fc9-10ed-6756ab42d5d7@gmail.com>
On Wed, Apr 07, 2021 at 09:16:44AM +0100, Beatriz Martins de Carvalho wrote:
>
> Em 07/04/21 06:37, Greg KH escreveu:
> > On Tue, Apr 06, 2021 at 09:00:07PM +0100, Beatriz Martins de Carvalho wrote:
> > > Em 06/04/21 20:36, Greg KH escreveu:
> > > > On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote:
> > > > > Cleans up check of "Lines should not end with a '('"
> > > > > with argument present in next line in file emxx_udc.c
> > > > >
> > > > > Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
> > > > > ---
> > > > > drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
> > > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > > Why is this a [RESEND] ?
> > > >
> > > > What happened to the first version?
> > > Sorry, I didn't receive your review, and in kernelnewbies tutorial, they say
> > > if not receive a response, may have missed the patch, so I resent it.
> > Do you have a pointer to your previous patch in the lore.kernel.org
> > archives anywhere? I can't seem to find it.
>
>
> I found this, it's what is you need?
>
> https://lore.kernel.org/linux-staging/20210401195457.24512-1-martinsdecarvalhobeatriz@gmail.com/
Ah, yes, I saw Julia's review and assumed you would fix up your patch
based on her comments. Please do not ignore review comments, it makes
everyone's lives harder.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-07 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 19:34 [RESEND PATCH] staging: emxx_udc: Ending line with argument Beatriz Martins de Carvalho
2021-04-06 19:36 ` Greg KH
2021-04-06 20:00 ` Beatriz Martins de Carvalho
2021-04-07 5:37 ` Greg KH
2021-04-07 8:16 ` Beatriz Martins de Carvalho
2021-04-07 8:34 ` Greg KH [this message]
2021-04-07 9:46 ` Beatriz Martins de Carvalho
2021-04-07 9:54 ` Greg KH
2021-04-06 19:56 ` [Outreachy kernel] " Matthew Wilcox
2021-04-06 20:12 ` Beatriz Martins de Carvalho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG1usolTNEOfDqXh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martinsdecarvalhobeatriz@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.