From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Thu, 8 Apr 2021 13:16:59 +0300 Subject: [PATCH v2 0/2] drivers: don't select DMA_CMA or CMA In-Reply-To: <20210408100523.63356-1-david@redhat.com> References: <20210408100523.63356-1-david@redhat.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Apr 08, 2021 at 12:05:21PM +0200, David Hildenbrand wrote: > Trying to set CONFIG_CMA=y with CONFIG_DMA_CMA=n revealed that we have > three drivers that select these options. Random drivers should not > override user settings of such core knobs. Let's use "imply DMA_CMA" > instead, such that user configuration and dependencies are respected. > > v1 -> v2: > - Fix DRM_CMA -> DMA_CMA > > Cc: Joel Stanley > Cc: David Airlie > Cc: Daniel Vetter > Cc: Andrew Jeffery > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: Mike Rapoport > Cc: Arnd Bergmann > Cc: Bartlomiej Zolnierkiewicz > Cc: Linus Walleij > Cc: Michal Simek > Cc: Masahiro Yamada > Cc: Randy Dunlap > Cc: Peter Collingbourne > Cc: linux-aspeed at lists.ozlabs.org > Cc: dri-devel at lists.freedesktop.org > Cc: linux-arm-kernel at lists.infradead.org > Cc: etnaviv at lists.freedesktop.org > Cc: linux-fbdev at vger.kernel.org > > David Hildenbrand (2): > drivers/video/fbdev: don't select DMA_CMA > drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv > > drivers/gpu/drm/aspeed/Kconfig | 3 +-- > drivers/gpu/drm/etnaviv/Kconfig | 3 +-- > drivers/video/fbdev/Kconfig | 2 +- > 3 files changed, 3 insertions(+), 5 deletions(-) Acked-by: Mike Rapoport > -- > 2.30.2 > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB074C433ED for ; Thu, 8 Apr 2021 10:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9080061176 for ; Thu, 8 Apr 2021 10:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbhDHKRX (ORCPT ); Thu, 8 Apr 2021 06:17:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbhDHKRW (ORCPT ); Thu, 8 Apr 2021 06:17:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B02961168; Thu, 8 Apr 2021 10:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617877031; bh=ivICCofV+HelFF0TfxwG+thYyuD+sKqQrEHToDgsMAA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UNNx+EGN0stAmujBkpKG7B+a3LZ9QOfURYpggW8gdYq7xt5P1gLMLgwM1dC5MpZ1P X7O4uDbSKKlPnIU+8/Y6gRxg4fPUuzhIsu8w6Fwb8B4xVKXHz8CvWH4QrtvBFITSEV Sxnv93leCr2IDHcwq6kptb/L86gB1Q+cqPtKBLHQ//heoRdly7V3dD/x0CXRA503pn 1M5OyO5KbAozxLmR9Dpq5Oefs1XuUJn5xBFlPTXTgFi1TPnK0/r/Y/ZRa7Exep2Gdn 1zCmFnWIMn66t09SBdrHP7u2VGOwHIiutu2GPaNpPda2430uojqFF+YO6UXZrmbRAJ /5bajopeTFScQ== Date: Thu, 8 Apr 2021 13:16:59 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2 0/2] drivers: don't select DMA_CMA or CMA Message-ID: References: <20210408100523.63356-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408100523.63356-1-david@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Thu, Apr 08, 2021 at 12:05:21PM +0200, David Hildenbrand wrote: > Trying to set CONFIG_CMA=y with CONFIG_DMA_CMA=n revealed that we have > three drivers that select these options. Random drivers should not > override user settings of such core knobs. Let's use "imply DMA_CMA" > instead, such that user configuration and dependencies are respected. > > v1 -> v2: > - Fix DRM_CMA -> DMA_CMA > > Cc: Joel Stanley > Cc: David Airlie > Cc: Daniel Vetter > Cc: Andrew Jeffery > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: Mike Rapoport > Cc: Arnd Bergmann > Cc: Bartlomiej Zolnierkiewicz > Cc: Linus Walleij > Cc: Michal Simek > Cc: Masahiro Yamada > Cc: Randy Dunlap > Cc: Peter Collingbourne > Cc: linux-aspeed@lists.ozlabs.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > > David Hildenbrand (2): > drivers/video/fbdev: don't select DMA_CMA > drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv > > drivers/gpu/drm/aspeed/Kconfig | 3 +-- > drivers/gpu/drm/etnaviv/Kconfig | 3 +-- > drivers/video/fbdev/Kconfig | 2 +- > 3 files changed, 3 insertions(+), 5 deletions(-) Acked-by: Mike Rapoport > -- > 2.30.2 > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBF4C433B4 for ; Thu, 8 Apr 2021 10:18:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9215261104 for ; Thu, 8 Apr 2021 10:18:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9215261104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DxGqsJItv1XS4dIQyg//nvbG2/VHsTMzg5USyWmqXPc=; b=Z7Rz9buAGAZAyBowqQvcP1Vwt 496811fOwj/rmjGXhRzuZdXsotfrIZXo57wrjeXPeXDWNJpR9t7lsSC5W9OdHylnQewS6o1oKiqqi GOWCd1bT2seiKAo068BOd0vnY3PYZ/u8fKUZpxfH8YkUxe+HcfSpDJJKgfR8xgI81bTQJ2pC+FCsW F/NdMXKGzQfPSG7FC0DJsllGOe5lIGKgTBIpObNXOjUUiLBd1JThdiVIT/SuglXT4Z5FisSuoz234 YXslME2NWdXldkbMj2f4TFMHK0zRP3XJimV/UFSzW+rcJDJxlCS/V54BZrlikwmNOLCVV6Bo1jyeT pBQs7UEXA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lURiw-007c1S-HD; Thu, 08 Apr 2021 10:17:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lURir-007c09-Cv for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 10:17:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B02961168; Thu, 8 Apr 2021 10:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617877031; bh=ivICCofV+HelFF0TfxwG+thYyuD+sKqQrEHToDgsMAA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UNNx+EGN0stAmujBkpKG7B+a3LZ9QOfURYpggW8gdYq7xt5P1gLMLgwM1dC5MpZ1P X7O4uDbSKKlPnIU+8/Y6gRxg4fPUuzhIsu8w6Fwb8B4xVKXHz8CvWH4QrtvBFITSEV Sxnv93leCr2IDHcwq6kptb/L86gB1Q+cqPtKBLHQ//heoRdly7V3dD/x0CXRA503pn 1M5OyO5KbAozxLmR9Dpq5Oefs1XuUJn5xBFlPTXTgFi1TPnK0/r/Y/ZRa7Exep2Gdn 1zCmFnWIMn66t09SBdrHP7u2VGOwHIiutu2GPaNpPda2430uojqFF+YO6UXZrmbRAJ /5bajopeTFScQ== Date: Thu, 8 Apr 2021 13:16:59 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v2 0/2] drivers: don't select DMA_CMA or CMA Message-ID: References: <20210408100523.63356-1-david@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210408100523.63356-1-david@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_111713_742772_27D95821 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 08, 2021 at 12:05:21PM +0200, David Hildenbrand wrote: > Trying to set CONFIG_CMA=y with CONFIG_DMA_CMA=n revealed that we have > three drivers that select these options. Random drivers should not > override user settings of such core knobs. Let's use "imply DMA_CMA" > instead, such that user configuration and dependencies are respected. > > v1 -> v2: > - Fix DRM_CMA -> DMA_CMA > > Cc: Joel Stanley > Cc: David Airlie > Cc: Daniel Vetter > Cc: Andrew Jeffery > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: Mike Rapoport > Cc: Arnd Bergmann > Cc: Bartlomiej Zolnierkiewicz > Cc: Linus Walleij > Cc: Michal Simek > Cc: Masahiro Yamada > Cc: Randy Dunlap > Cc: Peter Collingbourne > Cc: linux-aspeed@lists.ozlabs.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > > David Hildenbrand (2): > drivers/video/fbdev: don't select DMA_CMA > drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv > > drivers/gpu/drm/aspeed/Kconfig | 3 +-- > drivers/gpu/drm/etnaviv/Kconfig | 3 +-- > drivers/video/fbdev/Kconfig | 2 +- > 3 files changed, 3 insertions(+), 5 deletions(-) Acked-by: Mike Rapoport > -- > 2.30.2 > -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2641C43461 for ; Thu, 8 Apr 2021 10:17:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6485261176 for ; Thu, 8 Apr 2021 10:17:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6485261176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C0E66EA66; Thu, 8 Apr 2021 10:17:13 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1532D6EA65; Thu, 8 Apr 2021 10:17:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B02961168; Thu, 8 Apr 2021 10:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617877031; bh=ivICCofV+HelFF0TfxwG+thYyuD+sKqQrEHToDgsMAA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UNNx+EGN0stAmujBkpKG7B+a3LZ9QOfURYpggW8gdYq7xt5P1gLMLgwM1dC5MpZ1P X7O4uDbSKKlPnIU+8/Y6gRxg4fPUuzhIsu8w6Fwb8B4xVKXHz8CvWH4QrtvBFITSEV Sxnv93leCr2IDHcwq6kptb/L86gB1Q+cqPtKBLHQ//heoRdly7V3dD/x0CXRA503pn 1M5OyO5KbAozxLmR9Dpq5Oefs1XuUJn5xBFlPTXTgFi1TPnK0/r/Y/ZRa7Exep2Gdn 1zCmFnWIMn66t09SBdrHP7u2VGOwHIiutu2GPaNpPda2430uojqFF+YO6UXZrmbRAJ /5bajopeTFScQ== Date: Thu, 8 Apr 2021 13:16:59 +0300 From: Mike Rapoport To: David Hildenbrand Subject: Re: [PATCH v2 0/2] drivers: don't select DMA_CMA or CMA Message-ID: References: <20210408100523.63356-1-david@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210408100523.63356-1-david@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Arnd Bergmann , Bartlomiej Zolnierkiewicz , David Airlie , Andrew Jeffery , Randy Dunlap , etnaviv@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Simek , linux-mm@kvack.org, Joel Stanley , Russell King , Peter Collingbourne , Masahiro Yamada , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 08, 2021 at 12:05:21PM +0200, David Hildenbrand wrote: > Trying to set CONFIG_CMA=y with CONFIG_DMA_CMA=n revealed that we have > three drivers that select these options. Random drivers should not > override user settings of such core knobs. Let's use "imply DMA_CMA" > instead, such that user configuration and dependencies are respected. > > v1 -> v2: > - Fix DRM_CMA -> DMA_CMA > > Cc: Joel Stanley > Cc: David Airlie > Cc: Daniel Vetter > Cc: Andrew Jeffery > Cc: Lucas Stach > Cc: Russell King > Cc: Christian Gmeiner > Cc: Mike Rapoport > Cc: Arnd Bergmann > Cc: Bartlomiej Zolnierkiewicz > Cc: Linus Walleij > Cc: Michal Simek > Cc: Masahiro Yamada > Cc: Randy Dunlap > Cc: Peter Collingbourne > Cc: linux-aspeed@lists.ozlabs.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > > David Hildenbrand (2): > drivers/video/fbdev: don't select DMA_CMA > drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv > > drivers/gpu/drm/aspeed/Kconfig | 3 +-- > drivers/gpu/drm/etnaviv/Kconfig | 3 +-- > drivers/video/fbdev/Kconfig | 2 +- > 3 files changed, 3 insertions(+), 5 deletions(-) Acked-by: Mike Rapoport > -- > 2.30.2 > -- Sincerely yours, Mike. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel