All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, Brian Foster <bfoster@redhat.com>,
	linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCHSET 0/3] fstests: add inode btree blocks counters to the AGI header
Date: Sun, 28 Mar 2021 23:14:32 +0800	[thread overview]
Message-ID: <YGCdWPCGplgCkQPo@desktop> (raw)
In-Reply-To: <161647324459.3431131.16341235245632737552.stgit@magnolia>

On Mon, Mar 22, 2021 at 09:20:44PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> Years ago, Christoph diagnosed a problem where freeing an inode on a
> totally full filesystem could fail due to finobt expansion not being
> able to allocate enough blocks.  He solved the problem by using the
> per-AG block reservation system to ensure that there are always enough
> blocks for finobt expansion, but that came at the cost of having to walk
> the entire finobt at mount time.  This new feature solves that
> performance regression by adding inode btree block counts to the AGI
> header.  The patches in this series amend fstests to handle the new
> metadata fields and to test that upgrades work properly.

I've applied the first two patches, the third one seems need to be
revised.

Thanks,
Eryu

> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> kernel git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=inobt-counters
> 
> xfsprogs git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=inobt-counters
> 
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=inobt-counters
> ---
>  common/xfs        |   20 ++++++
>  tests/xfs/010     |    3 +
>  tests/xfs/030     |    2 +
>  tests/xfs/122.out |    2 -
>  tests/xfs/764     |  190 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/764.out |   27 ++++++++
>  tests/xfs/910     |   84 +++++++++++++++++++++++
>  tests/xfs/910.out |   12 +++
>  tests/xfs/group   |    2 +
>  9 files changed, 340 insertions(+), 2 deletions(-)
>  create mode 100755 tests/xfs/764
>  create mode 100644 tests/xfs/764.out
>  create mode 100755 tests/xfs/910
>  create mode 100644 tests/xfs/910.out

      parent reply	other threads:[~2021-03-28 15:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  4:20 [PATCHSET 0/3] fstests: add inode btree blocks counters to the AGI header Darrick J. Wong
2021-03-23  4:20 ` [PATCH 1/3] xfs/{010,030}: update repair output to deal with inobtcount feature Darrick J. Wong
2021-03-23  4:20 ` [PATCH 2/3] xfs/122: embiggen struct xfs_agi size for " Darrick J. Wong
2021-03-23  4:21 ` [PATCH 3/3] xfs: test inobtcount upgrade Darrick J. Wong
2021-03-23 14:13   ` Brian Foster
2021-03-23 18:54     ` Darrick J. Wong
2021-03-24 12:57       ` Brian Foster
2021-03-26  2:36         ` Darrick J. Wong
2021-03-27 14:35           ` Brian Foster
2021-03-28 15:12           ` Eryu Guan
2021-03-28 15:14 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGCdWPCGplgCkQPo@desktop \
    --to=guan@eryu.me \
    --cc=bfoster@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.