All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: Pavel Reichl <preichl@redhat.com>
Cc: fstests@vger.kernel.org, zlang@redhat.com, xzhou@redhat.com
Subject: Re: [PATCH 4/5] generic/554: hide permision warning on exfat
Date: Sun, 28 Mar 2021 23:40:58 +0800	[thread overview]
Message-ID: <YGCjirErrfGsmcGZ@desktop> (raw)
In-Reply-To: <20210326154134.309159-5-preichl@redhat.com>

On Fri, Mar 26, 2021 at 04:41:33PM +0100, Pavel Reichl wrote:
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> ---
>  tests/generic/554 | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/generic/554 b/tests/generic/554
> index fa4f97d2..365628e2 100755
> --- a/tests/generic/554
> +++ b/tests/generic/554
> @@ -46,7 +46,15 @@ $XFS_IO_PROG -f -c "pwrite -S 0x61 0 128k" $SCRATCH_MNT/file >> $seqres.full 2>&
>  
>  echo swap files return ETXTBUSY
>  _format_swapfile $SCRATCH_MNT/swapfile 16m
> -swapon $SCRATCH_MNT/swapfile
> +if [ "$FSTYP" = "exfat" ]; then
> +	# exfat does not support posix file permisions, so warning is
> +	# to be expected
> +	swapon $SCRATCH_MNT/swapfile 2>&1 |\
> +		grep -v 'insecure permission' >> $seqres.full
> +else
> +	swapon $SCRATCH_MNT/swapfile
> +fi

Introduce a new helper like _format_swapfile and do the check there?

Thanks,
Eryu

> +
>  $XFS_IO_PROG -f -c "copy_range -l 32k $SCRATCH_MNT/file" $SCRATCH_MNT/swapfile
>  swapoff $SCRATCH_MNT/swapfile
>  
> -- 
> 2.30.2

  parent reply	other threads:[~2021-03-28 15:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 15:41 [PATCH 0/5] Fix some tests that fail for exfat FS Pavel Reichl
2021-03-26 15:41 ` [PATCH 1/5] common: Add _require_{chown,chmod}() Pavel Reichl
2021-03-28 15:38   ` Eryu Guan
2021-03-26 15:41 ` [PATCH 2/5] g/87,88,125,126,128,193,314,317,355: Add _require_chown/chmod Pavel Reichl
2021-03-28 12:11   ` Zorro Lang
2021-03-26 15:41 ` [PATCH 3/5] common: hide permision warning from mkswap for exfat Pavel Reichl
2021-03-26 15:41 ` [PATCH 4/5] generic/554: hide permision warning on exfat Pavel Reichl
2021-03-28 13:06   ` Zorro Lang
2021-03-28 13:12     ` Zorro Lang
2021-03-28 15:40   ` Eryu Guan [this message]
2021-03-26 15:41 ` [PATCH 5/5] generic/003: Amend the test for exfat Pavel Reichl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGCjirErrfGsmcGZ@desktop \
    --to=guan@eryu.me \
    --cc=fstests@vger.kernel.org \
    --cc=preichl@redhat.com \
    --cc=xzhou@redhat.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.