From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D79B0C433C1 for ; Mon, 29 Mar 2021 11:04:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A09761938 for ; Mon, 29 Mar 2021 11:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbhC2LED (ORCPT ); Mon, 29 Mar 2021 07:04:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:51118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231735AbhC2LDu (ORCPT ); Mon, 29 Mar 2021 07:03:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6A2F461883; Mon, 29 Mar 2021 11:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617015830; bh=eKeLc/eUxq4hM0vTtXWv5c1gnqKwCfyDPdzZJI49lRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ig+lk1oU61xxoTGM5ALvhcXo3iGoh4jlwm5PkJ4uljdLJrwOdJUc871y6VMSeO01h IIWpkLpJFAIxrz0+2OmHJ+ckVIOnQTpfIZbN0w5HwB4xtGHlD4ly0/XvraMsYkTxSo 2RH3jXuVUjmnTNTibOCoSpzpSb/g4N06IvK3Ad+c= Date: Mon, 29 Mar 2021 13:03:47 +0200 From: Greg Kroah-Hartman To: Gustavo Pimentel Cc: "linux-doc@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Andrew Morton , Jonathan Corbet , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v9 4/4] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver Message-ID: References: <5840637a206dd1287caf142a0dbedf0dac9ccd48.1617011831.git.gustavo.pimentel@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Mar 29, 2021 at 10:53:38AM +0000, Gustavo Pimentel wrote: > On Mon, Mar 29, 2021 at 11:40:28, Greg Kroah-Hartman > wrote: > > > On Mon, Mar 29, 2021 at 10:25:25AM +0000, Gustavo Pimentel wrote: > > > On Mon, Mar 29, 2021 at 11:8:11, Greg Kroah-Hartman > > > wrote: > > > > > > > On Mon, Mar 29, 2021 at 11:59:40AM +0200, Gustavo Pimentel wrote: > > > > > This patch describes the sysfs interface implemented on the dw-xdata-pcie > > > > > driver. > > > > > > > > > > Signed-off-by: Gustavo Pimentel > > > > > --- > > > > > Documentation/ABI/testing/sysfs-driver-xdata | 46 ++++++++++++++++++++++++++++ > > > > > 1 file changed, 46 insertions(+) > > > > > create mode 100644 Documentation/ABI/testing/sysfs-driver-xdata > > > > > > > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-xdata b/Documentation/ABI/testing/sysfs-driver-xdata > > > > > new file mode 100644 > > > > > index 00000000..66af19a > > > > > --- /dev/null > > > > > +++ b/Documentation/ABI/testing/sysfs-driver-xdata > > > > > @@ -0,0 +1,46 @@ > > > > > +What: /sys/class/misc/drivers/dw-xdata-pcie./write > > > > > +Date: April 2021 > > > > > +KernelVersion: 5.13 > > > > > +Contact: Gustavo Pimentel > > > > > +Description: Allows the user to enable the PCIe traffic generator which > > > > > + will create write TLPs frames - from the Root Complex to the > > > > > + Endpoint direction. > > > > > + Usage e.g. > > > > > + echo 1 > /sys/class/misc/dw-xdata-pcie./write > > > > > > > > Again, this does not match the code. Either fix the code (which I > > > > recommend), or change this and the other sysfs descriptions of writing > > > > values here. > > > > > > I've commented about this previously, but I didn't get feedback on it, > > > therefore I assumed that justification was okay. > > > I will change the code to accept only the "1" input on the *_store() > > > > Why not use the built-in function to parse "1/y/Y" that the kernel > > provides for this type of thing? > > I found kstrtobool() just now. I'm adapting the code as we speak. > After testing I will send the v10 as soon as possible. There is no rush, take your time. greg k-h