From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Qiheng Lin <linqiheng@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mihai Carabas <mihai.carabas@oracle.com>,
zhenwei pi <pizhenwei@bytedance.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Joe Perches <joe@perches.com>,
Shile Zhang <shile.zhang@linux.alibaba.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] misc/pvpanic: fix return value check in pvpanic_pci_probe()
Date: Tue, 30 Mar 2021 12:27:49 +0300 [thread overview]
Message-ID: <YGLvFTWjEAOfs3db@smile.fi.intel.com> (raw)
In-Reply-To: <20210330013659.916-1-linqiheng@huawei.com>
On Tue, Mar 30, 2021 at 09:36:59AM +0800, Qiheng Lin wrote:
> In case of error, the function pci_iomap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
Error path there is broken completely, this is only one place you fix, but I
suggest to switch to devm*, pcim* APIs instead,
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-03-30 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 1:36 [PATCH -next] misc/pvpanic: fix return value check in pvpanic_pci_probe() Qiheng Lin
2021-03-30 9:27 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGLvFTWjEAOfs3db@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=shile.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.