Re: [PATCH dwarves v3] libbpf: allow to use packaged version

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Mar 30, 2021 at 01:47:05PM +0900, Dominique Martinet escreveu:
> Hi,
> 
> I see this commit has been reverted just before the 1.20 release in Feb:
> ---
> Revert "libbpf: allow to use packaged version"
> 
> This reverts commit 82749180b23d3c9c060108bc290ae26507fc324e.
> 
> Getting in the way of releasing 1.20, breaking the build of a dwarves
> rpm when a libbpf package is installed in a fedora 33 system:
> 
> In file included from /home/acme/rpmbuild/BUILD/dwarves-1.20/strings.c:7:
> /home/acme/rpmbuild/BUILD/dwarves-1.20/pahole_strings.h:9:10: fatal error: bpf/btf.h: No such file or directory
>     9 | #include <bpf/btf.h>
>       |          ^~~~~~~~~~~
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> 
> I can understand reverting due to other pressure to get a release out
> but most distros (including fedora) frown upon vendoring code so I think
> it would be good to have back ultimately.
> 
> Did you or someone else (Luca?) ever take the time to look at it?

Not yet, I'm right now working on it, testing patches to support clang's
thin-LTO being used to build the kernel, so busy with it.
 
> I don't see what would be so different with fedora to make this
> unfixable, I'd be happy taking a look if nobody has so far.

Please do.

> Would you take the patch back in if I somehow fix rpmbuild with a libbpf
> package installed on fedora33?

Sure. I had it merged, as, IIRC, it was a opt-in procedure.

- Arnaldo