All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org
Subject: Re: [PATCH] IMA: Fix error in comment
Date: Wed, 31 Mar 2021 05:54:06 +0300	[thread overview]
Message-ID: <YGPkTuoDhupnzuJB@kernel.org> (raw)
In-Reply-To: <20210330060845.18422-1-ribalda@chromium.org>

On Tue, Mar 30, 2021 at 08:08:45AM +0200, Ricardo Ribalda wrote:
> ima_file_mprotect does not return EACCES but EPERM.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>


Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko

> ---
>  security/integrity/ima/ima_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 9ef748ea829f..716ea29cf897 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -409,7 +409,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
>   * this point.  Eliminate this integrity gap by denying the mprotect
>   * PROT_EXECUTE change, if an mmap appraise policy rule exists.
>   *
> - * On mprotect change success, return 0.  On failure, return -EACESS.
> + * On mprotect change success, return 0.  On failure, return -EPERM.
>   */
>  int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
>  {
> -- 
> 2.31.0.291.g576ba9dcdaf-goog
> 
> 

      reply	other threads:[~2021-03-31  2:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  6:08 [PATCH] IMA: Fix error in comment Ricardo Ribalda
2021-03-31  2:54 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGPkTuoDhupnzuJB@kernel.org \
    --to=jarkko@kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ribalda@chromium.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.