From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] bugfix for ssetmask01.c
Date: Thu, 1 Apr 2021 08:12:27 +0200 [thread overview]
Message-ID: <YGVkS23e+/eytuEn@pevik> (raw)
In-Reply-To: <20210330021830.17402-1-zhanglianjie@uniontech.com>
Hi,
> mips architecture syscall(69) __NR_ssetmask not supported on your arch.
nit: "mips_o32: Fix __NR_s{g,s}etmask" for bug title would be more descriptive
than "bugfix for ssetmask01.c". And then in text mention ssetmask01.c.
> +++ b/include/lapi/syscalls/mips_o32.in
> @@ -66,8 +66,8 @@ getppid 64
> getpgrp 65
> setsid 66
> sigaction 67
> -sgetmask 68
> -ssetmask 69
> +sgetmask 4068
> +ssetmask 4069
But more important: I guess you're right because we don't add any offset to the
numbers. But IMHO all numbers are wrong, all mips files should contain offset
(01e4dc222 was wrong). mips_o32.in should be offset 4000, mips_n32.in 6000 and
mips_n64.in 5000 (comparing scall32-o32.S, scall64-64.S, scall64-n32.S in
arch/mips/kernel in kernel and mips{,n32,64}/bits/syscall.h.in in musl).
Kind regards,
Petr
next prev parent reply other threads:[~2021-04-01 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 2:18 [LTP] [PATCH] bugfix for ssetmask01.c zhanglianjie
2021-04-01 6:12 ` Petr Vorel [this message]
2021-04-02 4:38 ` He Zhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGVkS23e+/eytuEn@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.