From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E46C433ED for ; Thu, 1 Apr 2021 15:02:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12A4660C41 for ; Thu, 1 Apr 2021 15:02:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12A4660C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1841C6ECD3; Thu, 1 Apr 2021 15:02:16 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5395C6ECD3 for ; Thu, 1 Apr 2021 15:02:14 +0000 (UTC) IronPort-SDR: 20k/93Zx/wxGxKiTwaDB9oGREs3/MUn0vKi5gnTgKs2Awzsk/eHN5Xe816M3oNmo30f7AJMn/m pqTsNFAeVHxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="179394465" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="179394465" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 08:02:13 -0700 IronPort-SDR: 0ByJku4RogepxPBDShan5Z7Lwuiej4+DdtiaBGcsiK4EbsB6yPdSYKDldblvWPCzh/T1eDP3Sw xsLzinVH3xnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="446299292" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga002.fm.intel.com with SMTP; 01 Apr 2021 08:02:10 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 01 Apr 2021 18:02:10 +0300 Date: Thu, 1 Apr 2021 18:02:10 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Message-ID: References: <20210311144529.3059024-1-imre.deak@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210311144529.3059024-1-imre.deak@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: Uninit the DMC FW loader state during shutdown X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, kernel test robot Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Mar 11, 2021 at 04:45:29PM +0200, Imre Deak wrote: > We need to wait for the DMC FW loader work to complete during shutdown, > even if it's unlikely to be still pending by that time, fix this. > = > This also fixes the wakeref tracking WARN during shutdown about the > leaked reference we hold due to a missing DMC firmware. > = > While at it add a TODO comment about unifying the shutdown and PM > power-off sequences and later these sequences with the driver remove and > system/runtime suspend sequences. > = > Cc: Ville Syrj=E4l=E4 > References: https://lore.kernel.org/lkml/20210303055517.GB2708@xsang-Opti= Plex-9020 > Reported-by: kernel test robot > Signed-off-by: Imre Deak Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/i915_drv.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index 3edd5e47ad68..4a0e491e9692 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1038,10 +1038,18 @@ void i915_driver_shutdown(struct drm_i915_private= *i915) > intel_suspend_encoders(i915); > intel_shutdown_encoders(i915); > = > + intel_csr_ucode_suspend(i915); > + > /* > * The only requirement is to reboot with display DC states disabled, > * for now leaving all display power wells in the INIT power domain > - * enabled matching the driver reload sequence. > + * enabled. > + * > + * TODO: > + * - unify the pci_driver::shutdown sequence here with the > + * pci_driver.driver.pm.poweroff,poweroff_late sequence. > + * - unify the driver remove and system/runtime suspend sequences with > + * the above unified shutdown/poweroff sequence. > */ > intel_power_domains_driver_remove(i915); > enable_rpm_wakeref_asserts(&i915->runtime_pm); > -- = > 2.25.1 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx