From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 1/1] driver core: enable trace events (devres)
Date: Fri, 2 Apr 2021 01:34:09 +0200 [thread overview]
Message-ID: <YGZYcQLXejdKFzvd@kroah.com> (raw)
In-Reply-To: <20210401212129.82552-1-andriy.shevchenko@linux.intel.com>
On Fri, Apr 02, 2021 at 12:21:29AM +0300, Andy Shevchenko wrote:
> Enable trace events for driver core. For now only devres is supported.
That says _what_ this does, but not _why_ this is needed or wanted.
And you really don't even describe the "what" at all here either :(
Please be much more verbose when adding new features.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-01 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 21:21 [PATCH v1 1/1] driver core: enable trace events (devres) Andy Shevchenko
2021-04-01 23:34 ` Greg Kroah-Hartman [this message]
2021-04-01 23:44 ` kernel test robot
2021-04-01 23:44 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGZYcQLXejdKFzvd@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.