From: Greg KH <gregkh@linuxfoundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>,
keescook@chromium.org, dhowells@redhat.com, hch@infradead.org,
mbenes@suse.com, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, axboe@kernel.dk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate
Date: Fri, 2 Apr 2021 09:54:12 +0200 [thread overview]
Message-ID: <YGbNpLKXfWpy0ZZa@kroah.com> (raw)
In-Reply-To: <20210401235925.GR4332@42.do-not-panic.com>
On Thu, Apr 01, 2021 at 11:59:25PM +0000, Luis Chamberlain wrote:
> As for the syfs deadlock possible with drivers, this fixes it in a generic way:
>
> commit fac43d8025727a74f80a183cc5eb74ed902a5d14
> Author: Luis Chamberlain <mcgrof@kernel.org>
> Date: Sat Mar 27 14:58:15 2021 +0000
>
> sysfs: add optional module_owner to attribute
>
> This is needed as otherwise the owner of the attribute
> or group read/store might have a shared lock used on driver removal,
> and deadlock if we race with driver removal.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
No, please no. Module removal is a "best effort", if the system dies
when it happens, that's on you. I am not willing to expend extra energy
and maintance of core things like sysfs for stuff like this that does
not matter in any system other than a developer's box.
Lock data, not code please. Trying to tie data structure's lifespans
to the lifespan of code is a tangled mess, and one that I do not want to
add to in any form.
sorry,
greg k-h
next prev parent reply other threads:[~2021-04-02 7:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 2:20 [PATCH 0/2] zram: fix few ltp zram02.sh crashes Luis Chamberlain
2021-03-06 2:20 ` [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate Luis Chamberlain
2021-03-09 2:55 ` Minchan Kim
2021-03-10 13:11 ` Luis Chamberlain
2021-03-10 21:25 ` Luis Chamberlain
2021-03-12 2:08 ` Minchan Kim
2021-03-10 21:21 ` Luis Chamberlain
2021-03-12 2:14 ` Minchan Kim
2021-03-12 18:32 ` Luis Chamberlain
2021-03-12 19:28 ` Minchan Kim
2021-03-19 19:09 ` Luis Chamberlain
2021-03-22 16:37 ` Minchan Kim
2021-03-22 20:41 ` Luis Chamberlain
2021-03-22 22:12 ` Minchan Kim
2021-04-01 23:59 ` Luis Chamberlain
2021-04-02 7:54 ` Greg KH [this message]
2021-04-02 18:30 ` Luis Chamberlain
2021-04-03 6:13 ` Greg KH
[not found] ` <20210406003152.GZ4332@42.do-not-panic.com>
2021-04-06 12:00 ` Miroslav Benes
2021-04-06 15:54 ` Josh Poimboeuf
2021-04-07 14:09 ` Peter Zijlstra
2021-04-07 15:30 ` Josh Poimboeuf
2021-04-07 16:48 ` Peter Zijlstra
2021-04-07 20:17 ` Josh Poimboeuf
2021-04-08 6:18 ` Greg KH
2021-04-08 13:16 ` Steven Rostedt
2021-04-08 13:37 ` Josh Poimboeuf
2021-04-08 1:37 ` Thomas Gleixner
2021-04-08 6:16 ` Greg KH
2021-04-08 8:01 ` Jiri Kosina
2021-04-08 8:09 ` Greg KH
2021-04-08 8:35 ` Jiri Kosina
2021-04-08 8:55 ` Greg KH
2021-04-08 18:40 ` Luis Chamberlain
2021-04-09 3:01 ` Kees Cook
2021-04-05 17:07 ` Minchan Kim
2021-04-05 19:00 ` Luis Chamberlain
2021-04-05 19:58 ` Minchan Kim
2021-04-06 0:29 ` Luis Chamberlain
2021-04-07 1:23 ` Minchan Kim
2021-04-07 1:38 ` Minchan Kim
2021-04-07 14:52 ` Luis Chamberlain
2021-04-07 14:50 ` Luis Chamberlain
2021-03-06 2:20 ` [PATCH 2/2] zram: fix races of sysfs attribute removal and usage Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGbNpLKXfWpy0ZZa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.