From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org, Wang Shilong <wshilong@whamcloud.com>
Subject: Re: [PATCH] filefrag: minor usability improvements
Date: Fri, 2 Apr 2021 16:05:09 -0400 [thread overview]
Message-ID: <YGd49Qv6GLIKPZ8+@mit.edu> (raw)
In-Reply-To: <20210310224715.18467-1-adilger@whamcloud.com>
On Wed, Mar 10, 2021 at 03:47:15PM -0700, Andreas Dilger wrote:
> Add '-V' to filefrag to print the installed version of the tool.
>
> If '-V' is used twice, print out the list of supported FIEMAP flags.
> This can be used to check if filefrag understands a specific feature.
>
> Include FIEMAP in the error message printed when filefrag cannot
> get the file layout. Since FIEMAP is commonly available and tried
> first, it should also be mentioned in the error message unless it
> was requested to only run FIBMAP.
>
> Update filefrag.1.in man page to cover the new -V option.
>
> Fix a formatting error with the recently added '-P' options, and
> include '-E' and '-P' in the SYNOPSIS section.
>
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-11848
> Reviewed-by: Wang Shilong <wshilong@whamcloud.com>
> Change-Id: Ib126bdd70efa1775aef6db761f54e27a593ebbe5
Applied, thanks.
- Ted
prev parent reply other threads:[~2021-04-02 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 22:47 [PATCH] filefrag: minor usability improvements Andreas Dilger
2021-04-02 20:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGd49Qv6GLIKPZ8+@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wshilong@whamcloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.