All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ivan Safonov <insafonov@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Michael Straube <straube.linux@gmail.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Peilin Ye <yepeilin.cs@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction()
Date: Sun, 4 Apr 2021 11:56:40 +0200	[thread overview]
Message-ID: <YGmNWIFSvtOB84Ds@kroah.com> (raw)
In-Reply-To: <8955077a-94b6-9ffb-d2f6-b611845b6cfc@gmail.com>

On Sun, Apr 04, 2021 at 12:30:41AM +0300, Ivan Safonov wrote:
> On 4/2/21 4:04 PM, Greg Kroah-Hartman wrote:
> > On Sun, Mar 28, 2021 at 07:33:25PM +0300, Ivan Safonov wrote:
> > > on_action_spct() do nothing, because rtw_get_stainfo() has no side
> > > effects. Other action handlers are trivial.
> > > 
> > > Signed-off-by: Ivan Safonov <insafonov@gmail.com>
> > 
> > Same here, wrong driver name :(
> > 
> 
> Driver name is "r8188eu"...
> 
> $ grep 'r8188eu' drivers/staging/rtl8188eu/include/drv_types.h

Directory name is "rtl8188eu", so something needs to be fixed up here to
remove confusion like this :)

thanks,

greg k-h

  reply	other threads:[~2021-04-04  9:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 16:33 [PATCH 1/2] staging:r8188eu: refactor OnAction(): use switch instead table lookup Ivan Safonov
2021-03-28 16:33 ` [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction() Ivan Safonov
2021-04-02 13:04   ` Greg Kroah-Hartman
2021-04-03 21:30     ` Ivan Safonov
2021-04-04  9:56       ` Greg Kroah-Hartman [this message]
2021-04-02 13:04 ` [PATCH 1/2] staging:r8188eu: refactor OnAction(): use switch instead table lookup Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGmNWIFSvtOB84Ds@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gustavoars@kernel.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    --cc=yepeilin.cs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.