From: Greg KH <gregkh@linuxfoundation.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Mon, 5 Apr 2021 08:37:13 +0200 [thread overview]
Message-ID: <YGqwGeSCdJwH33od@kroah.com> (raw)
In-Reply-To: <OSBPR01MB477323303D45865B0B2AD96CBA779@OSBPR01MB4773.jpnprd01.prod.outlook.com>
On Mon, Apr 05, 2021 at 01:52:39AM +0000, Min Li wrote:
> >
> > Any specific reason you are not using the misc_device api? That would clean
> > up this driver a lot, there's no need to create a whole class just for a single
> > driver.
> >
>
> Hi Greg
>
> No specific reason. I just didn't know the existence of misc_register API.
Your file is in drivers/misc/ :)
> Do you recommend using this API to create the device?
Yes.
> If yes, can you tell me how to obtain a appropriate MINOR number from
> miscdevice.h?
No need to reserve one, we don't do that anymore, just ask for a dynamic
value and the next availble one will be given to your driver
automatically.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-05 6:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 22:08 [PATCH next 1/2] mfd: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-04-03 22:08 ` [PATCH next 2/2] misc: " min.li.xe
2021-04-04 10:08 ` Greg KH
2021-04-05 1:52 ` Min Li
2021-04-05 6:37 ` Greg KH [this message]
2021-04-05 13:53 ` Min Li
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 15:34 min.li.xe
2021-03-27 7:58 ` kernel test robot
2021-03-27 7:58 ` kernel test robot
2021-03-27 9:53 ` kernel test robot
2021-03-27 9:53 ` kernel test robot
2021-03-28 12:13 ` Greg KH
2021-03-29 17:03 ` Min Li
2021-04-02 14:22 ` Greg KH
2021-04-03 22:06 ` Min Li
2021-03-23 16:40 min.li.xe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGqwGeSCdJwH33od@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.