From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Arnd Bergmann <arnd@kernel.org>, Jan Kara <jack@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
Mauricio Faria de Oliveira <mfo@canonical.com>,
Andreas Dilger <adilger@dilger.ca>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"zhangyi (F)" <yi.zhang@huawei.com>,
Alexander Lochmann <alexander.lochmann@tu-dortmund.de>,
Hui Su <sh_def@163.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd2: avoid -Wempty-body warnings
Date: Mon, 5 Apr 2021 22:39:50 -0400 [thread overview]
Message-ID: <YGvJ9vQftwVC9S7h@mit.edu> (raw)
In-Reply-To: <20210330151533.GA10067@quack2.suse.cz>
On Tue, Mar 30, 2021 at 05:15:33PM +0200, Jan Kara wrote:
> On Mon 22-03-21 11:21:38, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Building with 'make W=1' shows a harmless -Wempty-body warning:
> >
> > fs/jbd2/recovery.c: In function 'fc_do_one_pass':
> > fs/jbd2/recovery.c:267:75: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> > 267 | jbd_debug(3, "Fast commit replay failed, err = %d\n", err);
> > | ^
> >
> > Change the empty dprintk() macros to no_printk(), which avoids this
> > warning and adds format string checking.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Sure. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2021-04-06 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 10:21 [PATCH] jbd2: avoid -Wempty-body warnings Arnd Bergmann
2021-03-30 15:15 ` Jan Kara
2021-04-06 2:39 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGvJ9vQftwVC9S7h@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=alexander.lochmann@tu-dortmund.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mfo@canonical.com \
--cc=sh_def@163.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.