From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Correct indentation in Hal8723BReg.h
Date: Tue, 6 Apr 2021 07:12:20 +0200 [thread overview]
Message-ID: <YGvttKG+RNhKAmO/@kroah.com> (raw)
In-Reply-To: <20210406020815.22995-1-fmdefrancesco@gmail.com>
On Tue, Apr 06, 2021 at 04:08:15AM +0200, Fabio M. De Francesco wrote:
> Correct indentation issues of many #define and comments in Hal8723BReg.h
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 604 ++++++++++----------
> 1 file changed, 302 insertions(+), 302 deletions(-)
You forgot to cc: all of the needed mailing lists. And your subject
line needs some work. But the biggest issue is that I do not understand
what this patch does at all. What is wrong with the original code here
that required you to "correct" it?
confused,
greg k-h
next prev parent reply other threads:[~2021-04-06 5:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 2:08 [PATCH] Correct indentation in Hal8723BReg.h Fabio M. De Francesco
2021-04-06 5:12 ` Greg KH [this message]
2021-04-06 5:52 ` Fabio M. De Francesco
2021-04-06 6:00 ` Fabio M. De Francesco
2021-04-06 6:40 ` [Outreachy kernel] " Julia Lawall
2021-04-06 7:08 ` Fabio M. De Francesco
2021-04-06 7:22 ` Greg KH
2021-04-06 7:27 ` Julia Lawall
2021-04-06 7:46 ` FMDF
2021-04-06 8:01 ` Julia Lawall
2021-04-06 8:38 ` Fabio M. De Francesco
2021-04-06 8:44 ` Julia Lawall
2021-04-06 6:43 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGvttKG+RNhKAmO/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.