From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6443C433B4 for ; Wed, 21 Apr 2021 08:48:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1590161425 for ; Wed, 21 Apr 2021 08:48:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1590161425 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W8AALPM2O6EfotBl2yZRNsOa/Fcvnnt06TLvuPA6rlY=; b=p+bjZG5nGsPqMC1w7fDJRsHGD TdesXqf4uoGJD8sxWfosuotWyj9Gtvm6MC/qKIf+hB3OJ3kTFIxj6b8fgyUmhzxb104R4502VAczt kVR0RTrSSLHxVCIEBz7XmEH0iwkNlm1KPXVX/mMGMz0gRNjCWwycJVF/JP+eeV6vbqAGOYi/NPp2n 2bEY2bnt2Gf8bMMij3ULIudR3DyF1e857a5MrkgIbnb+6khJYMGT2qQGqdNH9GBsT/KAg5sxwrCGj kZvPa5i8z4enF2UjVd1vfJH+aLD6gWENXbEMO0lp+rD21dp3IfulENC0o+Ofrcg9jHoEIoIyBjE1+ i2SZPQhEQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZ8Ue-00E0De-Tv; Wed, 21 Apr 2021 08:45:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZ8UZ-00E0DF-1S for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 08:45:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=iVsBBg4XWszZYxncrfSNo32bD1 vPjE+CmMlwTMKqof/Ub6EZ9PHQpvPvsNEQX64MVEL6q3zzLyIKusEH6PSX4cP93xsQTc0RF1ssn8G DRTkXm7guh1xVBlBzHFzaD77EcPmE6pOoRsX5oFdcd+fUM/NyO2g2gl76UrNsGw/kA141SDMdfU2T TdiVYbNYvadjo5ZE7HDP/hGzXtd7sH7mpF/oES0ple6HhwUl5Fjs3sgewQHKubn5fT9PbzPFbPktF RuhIxkNc8yJfPSN4iQHOXShDDtk8nG0FDnG5qf2fGpD+ges3GiX7v53FQx3j3UHAMCVIXluFqPZ1B aE7BEzEw==; Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZ8UV-00CihE-HD for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 08:45:49 +0000 Received: by mail-wr1-x435.google.com with SMTP id h4so31425011wrt.12 for ; Wed, 21 Apr 2021 01:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=PKuxgMvuAnY4j3XFS5LDSlKmE9K0hmcw+6xcrwyF5EYk7C+8Q8rY09FX5klV91bQ+H oxmSb48NV+BkZM2nurcQFUv1xeSoPd8ubDufrdjItZVFace8Vy9HXrRYrLCvASct4xst k2HVS4BbQnxp0VWuIYmqyQEC00n+oyX/PUzMbomZhrRxe1W5qS/8vi/xIpyFSfSRyQGR VD0ijrBlEJVy0twXMsrs3GbESBEL9NBaTOoV8sRIGfz8wN0dTLTFKO9tLjT7A+yyVTuj 95XwzYTffbWs4+c3mq8VdLDECQASB+DEPMqJcnV/smKRAqP6IVD5PKCha4TOYf9mBp/n 4DeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=QjBVIJ09KmmWPxXJE0tpNOESk+egmO1HbgXNN638fi6/kmPMYOd3ddN7ZatGsGimsC qZp8ugI4ioRgWYFsQFjql6CKHJmJUtxpK4xfZBEu/Bvvp/OvdD7uON6HI4SAJ/UI8Mfo EpurzlOQB7IE0MyDIctLlzk61bQHz9a4DC/5XkmxJ5dK9q7hbNxqYEWMTBeoyEzM4N9G ZGOirPe618E1lUjz4x9tunDjINZV/5DizkYorJi/B2d/f1ysC6kxf9tIWKgFE9RWV3wF 6e4JdIXi/O/tUL0hGlYdZgddzGDDzTvvmMpRD1s0j+MY1r0Zw7zXdh2uZpWIBb/WYMqB 4qfA== X-Gm-Message-State: AOAM533oFo4I/1xRGfQSf39XS2VicpAnPtqDS/1UqsyPfI0CpoJGk94z rRUQeBW1sdXxz/nJemcx5mcHSA== X-Google-Smtp-Source: ABdhPJxLbEgvbfDHrIA7WnlMIVdZHppOGkiCV3bbFTTWBqmRn3tbZ6PUlt6yVY2Qyreu5khHX/9XXQ== X-Received: by 2002:adf:f081:: with SMTP id n1mr25780163wro.137.1618994745796; Wed, 21 Apr 2021 01:45:45 -0700 (PDT) Received: from google.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id s8sm2246313wrn.97.2021.04.21.01.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 01:45:45 -0700 (PDT) Date: Wed, 21 Apr 2021 08:45:42 +0000 From: Quentin Perret To: Florian Fainelli Cc: Ard Biesheuvel , Rob Herring , Alexandre TORGUE , Greg Kroah-Hartman , Sasha Levin , stable , Arnd Bergmann , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Nicolas Boichat , Stephen Boyd , KarimAllah Ahmed , Android Kernel Team , Architecture Mailman List , Frank Rowand , linux-arm-kernel Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Message-ID: References: <4a4734d6-49df-677b-71d3-b926c44d89a9@foss.st.com> <001f8550-b625-17d2-85a6-98a483557c70@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_014547_611085_0A8CBA70 X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 21 Apr 2021 at 08:31:00 (+0000), Quentin Perret wrote: > FWIW I did test this on Qemu before posting. With 5.12-rc8 and a 1MiB > no-map region at 0x80000000, I have the following: > > 40000000-7fffffff : System RAM > 40210000-417fffff : Kernel code > 41800000-41daffff : reserved > 41db0000-4210ffff : Kernel data > 48000000-48008fff : reserved > 80000000-800fffff : reserved > 80100000-13fffffff : System RAM > fa000000-ffffffff : reserved > 13b000000-13f5fffff : reserved > 13f6de000-13f77dfff : reserved > 13f77e000-13f77efff : reserved > 13f77f000-13f7dafff : reserved > 13f7dd000-13f7defff : reserved > 13f7df000-13f7dffff : reserved > 13f7e0000-13f7f3fff : reserved > 13f7f4000-13f7fdfff : reserved > 13f7fe000-13fffffff : reserved > > If I remove the 'no-map' qualifier from DT, I get this: > > 40000000-13fffffff : System RAM > 40210000-417fffff : Kernel code > 41800000-41daffff : reserved > 41db0000-4210ffff : Kernel data > 48000000-48008fff : reserved > 80000000-800fffff : reserved > fa000000-ffffffff : reserved > 13b000000-13f5fffff : reserved > 13f6de000-13f77dfff : reserved > 13f77e000-13f77efff : reserved > 13f77f000-13f7dafff : reserved > 13f7dd000-13f7defff : reserved > 13f7df000-13f7dffff : reserved > 13f7e0000-13f7f3fff : reserved > 13f7f4000-13f7fdfff : reserved > 13f7fe000-13fffffff : reserved > > So this does seem to be working fine on my setup. I'll try again with > 5.4 to see if I can repro. I just ran the same experiment on v5.4.102 which is where the regression was reported, and I'm seeing the same correct result... > Also, 8a5a75e5e9e5 ("of/fdt: Make sure no-map does not remove already > reserved regions") looks more likely to cause the issue observed here, > but that shouldn't be silent. I get the following error message in dmesg > if I if place the no-map region on top of the kernel image: > > OF: fdt: Reserved memory: failed to reserve memory for node 'foobar@40210000': base 0x0000000040210000, size 1 MiB > > Is that triggering on your end? So that really sounds like the cause of the issue here, though arguably this should be indicative a something funny in the DT. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1EDC433B4 for ; Wed, 21 Apr 2021 08:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A633613D7 for ; Wed, 21 Apr 2021 08:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237197AbhDUIqV (ORCPT ); Wed, 21 Apr 2021 04:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234885AbhDUIqV (ORCPT ); Wed, 21 Apr 2021 04:46:21 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3509EC06138B for ; Wed, 21 Apr 2021 01:45:47 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id c4so1533643wrt.8 for ; Wed, 21 Apr 2021 01:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=PKuxgMvuAnY4j3XFS5LDSlKmE9K0hmcw+6xcrwyF5EYk7C+8Q8rY09FX5klV91bQ+H oxmSb48NV+BkZM2nurcQFUv1xeSoPd8ubDufrdjItZVFace8Vy9HXrRYrLCvASct4xst k2HVS4BbQnxp0VWuIYmqyQEC00n+oyX/PUzMbomZhrRxe1W5qS/8vi/xIpyFSfSRyQGR VD0ijrBlEJVy0twXMsrs3GbESBEL9NBaTOoV8sRIGfz8wN0dTLTFKO9tLjT7A+yyVTuj 95XwzYTffbWs4+c3mq8VdLDECQASB+DEPMqJcnV/smKRAqP6IVD5PKCha4TOYf9mBp/n 4DeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nF07lGmK8d790hYBNTxLzN+JqkeiBDMUtoFoxeafsPs=; b=qw53lJs6YZ2yW6cqTgOxkh10J/cYtW+nnZt1HDjt5+IANQGly3rEF9rr4SBhFZ8pOk t9DFTBg909z37uN+XXRwq5tt4Ks/z+/6QhSgD81sNbUQzo381iNBNMUp5OMStIKIbfo+ NkNZoZpr0FXkXIJmXp8jB0itP3nguvT/mEDPgFcwM9kmmtYD1avl/wTGdXQbY4Re7pdF jir8W1VjMbks+cvytV64ieKNtH/3nDvsCRMgYD142KEYdukgL2JelPES8KwL7rzEhfSM AvcOm1kgI1JHN7Ba+ZcCz/OoPWWGhVaxVQA2i96V55JapISIaT/JSDHyQbxKufZ8in3u oZDw== X-Gm-Message-State: AOAM533zaeN+RYw6ja1wrpD/sJUkDT5n4vCKt5t/snrkR42mAt9ST8iC hu0TSUampXBuIWrjzFWKa+B9YQ== X-Google-Smtp-Source: ABdhPJxLbEgvbfDHrIA7WnlMIVdZHppOGkiCV3bbFTTWBqmRn3tbZ6PUlt6yVY2Qyreu5khHX/9XXQ== X-Received: by 2002:adf:f081:: with SMTP id n1mr25780163wro.137.1618994745796; Wed, 21 Apr 2021 01:45:45 -0700 (PDT) Received: from google.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id s8sm2246313wrn.97.2021.04.21.01.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 01:45:45 -0700 (PDT) Date: Wed, 21 Apr 2021 08:45:42 +0000 From: Quentin Perret To: Florian Fainelli Cc: Ard Biesheuvel , Rob Herring , Alexandre TORGUE , Greg Kroah-Hartman , Sasha Levin , stable , Arnd Bergmann , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Nicolas Boichat , Stephen Boyd , KarimAllah Ahmed , Android Kernel Team , Architecture Mailman List , Frank Rowand , linux-arm-kernel Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Message-ID: References: <4a4734d6-49df-677b-71d3-b926c44d89a9@foss.st.com> <001f8550-b625-17d2-85a6-98a483557c70@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wednesday 21 Apr 2021 at 08:31:00 (+0000), Quentin Perret wrote: > FWIW I did test this on Qemu before posting. With 5.12-rc8 and a 1MiB > no-map region at 0x80000000, I have the following: > > 40000000-7fffffff : System RAM > 40210000-417fffff : Kernel code > 41800000-41daffff : reserved > 41db0000-4210ffff : Kernel data > 48000000-48008fff : reserved > 80000000-800fffff : reserved > 80100000-13fffffff : System RAM > fa000000-ffffffff : reserved > 13b000000-13f5fffff : reserved > 13f6de000-13f77dfff : reserved > 13f77e000-13f77efff : reserved > 13f77f000-13f7dafff : reserved > 13f7dd000-13f7defff : reserved > 13f7df000-13f7dffff : reserved > 13f7e0000-13f7f3fff : reserved > 13f7f4000-13f7fdfff : reserved > 13f7fe000-13fffffff : reserved > > If I remove the 'no-map' qualifier from DT, I get this: > > 40000000-13fffffff : System RAM > 40210000-417fffff : Kernel code > 41800000-41daffff : reserved > 41db0000-4210ffff : Kernel data > 48000000-48008fff : reserved > 80000000-800fffff : reserved > fa000000-ffffffff : reserved > 13b000000-13f5fffff : reserved > 13f6de000-13f77dfff : reserved > 13f77e000-13f77efff : reserved > 13f77f000-13f7dafff : reserved > 13f7dd000-13f7defff : reserved > 13f7df000-13f7dffff : reserved > 13f7e0000-13f7f3fff : reserved > 13f7f4000-13f7fdfff : reserved > 13f7fe000-13fffffff : reserved > > So this does seem to be working fine on my setup. I'll try again with > 5.4 to see if I can repro. I just ran the same experiment on v5.4.102 which is where the regression was reported, and I'm seeing the same correct result... > Also, 8a5a75e5e9e5 ("of/fdt: Make sure no-map does not remove already > reserved regions") looks more likely to cause the issue observed here, > but that shouldn't be silent. I get the following error message in dmesg > if I if place the no-map region on top of the kernel image: > > OF: fdt: Reserved memory: failed to reserve memory for node 'foobar@40210000': base 0x0000000040210000, size 1 MiB > > Is that triggering on your end? So that really sounds like the cause of the issue here, though arguably this should be indicative a something funny in the DT. Thanks, Quentin