From: Dan Carpenter <dan.carpenter@oracle.com>
To: bryan.odonoghue@linaro.org
Cc: linux-media@vger.kernel.org
Subject: [bug report] media: venus: hfi,pm,firmware: Convert to block relative addressing
Date: Fri, 9 Apr 2021 15:19:17 +0300 [thread overview]
Message-ID: <YHBGRasttETWBHxW@mwanda> (raw)
Hello Bryan O'Donoghue,
This is a semi-automatic email about new static checker warnings.
The patch ff2a7013b3e6: "media: venus: hfi,pm,firmware: Convert to
block relative addressing" from Apr 2, 2021, leads to the following
Smatch complaint:
drivers/media/platform/qcom/venus/hfi_venus.c:1100 venus_isr()
warn: variable dereferenced before check 'hdev' (see line 1097)
drivers/media/platform/qcom/venus/hfi_venus.c
1096 u32 status;
1097 void __iomem *cpu_cs_base = hdev->core->cpu_cs_base;
^^^^^^^^^^
1098 void __iomem *wrapper_base = hdev->core->wrapper_base;
^^^^^^^^^^
The patch adds new unchecked dereferences before ...
1099
1100 if (!hdev)
^^^^^
... this check.
1101 return IRQ_NONE;
1102
regards,
dan carpenter
next reply other threads:[~2021-04-09 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:19 Dan Carpenter [this message]
2021-04-09 12:28 ` [bug report] media: venus: hfi,pm,firmware: Convert to block relative addressing Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHBGRasttETWBHxW@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.